]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
soundwire: qcom: set controller id to hw master id
authorSrinivas Kandagatla <srinivas.kandagatla@linaro.org>
Thu, 23 Nov 2023 10:53:32 +0000 (10:53 +0000)
committerVinod Koul <vkoul@kernel.org>
Fri, 24 Nov 2023 06:56:26 +0000 (12:26 +0530)
Qualcomm Soundwire Controllers IP version after 1.3 have a dedicated
master id register which will provide a unique id value for each
controller instance. Use this value instead of artificially generated
value from idr. Versions 1.3 and below only have one instance of
soundwire controller which does no have this register, so let them use
value from idr.

Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Tested-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/20231123105332.102167-1-srinivas.kandagatla@linaro.org
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/soundwire/qcom.c

index 7f8549aab42f329b21dc11dbd7524306a521543a..d869e2276815c6439062217acbb9387c4b015ca4 100644 (file)
@@ -1620,9 +1620,13 @@ static int qcom_swrm_probe(struct platform_device *pdev)
                }
        }
 
-       /* FIXME: is there a DT-defined value to use ? */
        ctrl->bus.controller_id = -1;
 
+       if (ctrl->version > SWRM_VERSION_1_3_0) {
+               ctrl->reg_read(ctrl, SWRM_COMP_MASTER_ID, &val);
+               ctrl->bus.controller_id = val;
+       }
+
        ret = sdw_bus_master_add(&ctrl->bus, dev, dev->fwnode);
        if (ret) {
                dev_err(dev, "Failed to register Soundwire controller (%d)\n",