]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
net/mlx5e: Update features on ring size change
authorDragos Tatulea <dtatulea@nvidia.com>
Thu, 24 Oct 2024 16:41:33 +0000 (19:41 +0300)
committerJakub Kicinski <kuba@kernel.org>
Tue, 29 Oct 2024 18:48:26 +0000 (11:48 -0700)
When the ring size changes successfully, trigger
netdev_update_features() to enable features in wanted state if
applicable.

An example of such scenario:
$ ip link set dev eth1 up
$ ethtool --set-ring eth1 rx 8192
$ ip link set dev eth1 mtu 9000
$ ethtool --features eth1 rx-gro-hw on --> fails
$ ethtool --set-ring eth1 rx 1024

With this patch, HW GRO will be turned on automatically because
it is set in the device's wanted_features.

Signed-off-by: Dragos Tatulea <dtatulea@nvidia.com>
Reviewed-by: Gal Pressman <gal@nvidia.com>
Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20241024164134.299646-3-tariqt@nvidia.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c

index 1966736f98b4af04f59f257045776b4ba1e25bf1..cae39198b4dbc7034f0cffee65fbc329488e9600 100644 (file)
@@ -406,6 +406,9 @@ int mlx5e_ethtool_set_ringparam(struct mlx5e_priv *priv,
 unlock:
        mutex_unlock(&priv->state_lock);
 
+       if (!err)
+               netdev_update_features(priv->netdev);
+
        return err;
 }