fs: ext4fs: Do not negate error before returning it

In ext4fs_readdir it calls ext4fs_read_file and checks the return value
for non-zero to detect an error. This return value should be returned as
is rather than being negated.

This issue found by Smatch

Signed-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>

diff --git a/fs/ext4/ext4fs.c b/fs/ext4/ext4fs.c
index 1727da2dc6db089b1d5805be156f5ade5d7c0afa..7fb4c1b755b1d347f70433e4af71948e8b2e5898 100644 (file)
--- a/fs/ext4/ext4fs.c
+++ b/fs/ext4/ext4fs.c
@@ -272,7 +272,7 @@ int ext4fs_readdir(struct fs_dir_stream *fs_dirs, struct fs_dirent **dentp)
                                       sizeof(struct ext2_dirent),
                                       (char *)&dirent, &actread);
                if (ret < 0)
-                       return -ret;
+                       return ret;
 
                if (!dirent.direntlen)
                        return -EIO;