ldb: Fix maybe-uninitialized warning

In file included from ../../lib/ldb/include/ldb.h:50,
                 from ../../lib/ldb/include/ldb_private.h:43,
                 from ../../lib/ldb/common/ldb_pack.c:34:
../../lib/ldb/common/ldb_pack.c: In function ‘ldb_filter_attrs’:
../../lib/talloc/talloc.h:1173:48: error: ‘i’ may be used uninitialized [-Werror=maybe-uninitialized]
 1173 | #define talloc_array(ctx, type, count) (type *)_talloc_array(ctx, sizeof(type), count, #type)
      |                                                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../lib/ldb/common/ldb_pack.c:1178:34: note: in expansion of macro ‘talloc_array’
 1178 |         filtered_msg->elements = talloc_array(filtered_msg,
      |                                  ^~~~~~~~~~~~
../../lib/ldb/common/ldb_pack.c:1134:22: note: ‘i’ was declared here
 1134 |         unsigned int i;
      |                      ^
cc1: all warnings being treated as errors

Signed-off-by: Jennifer Sutton <jennifersutton@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>

diff --git a/lib/ldb/common/ldb_pack.c b/lib/ldb/common/ldb_pack.c
index 409be59061159dacb0dd8805a7ddc612a7bdbf2e..86701ad7e71020c5f48abfabd89793d6c76b16bd 100644 (file)
--- a/lib/ldb/common/ldb_pack.c
+++ b/lib/ldb/common/ldb_pack.c
@@ -1131,7 +1131,7 @@ int ldb_filter_attrs(struct ldb_context *ldb,
                     const char *const *attrs,
                     struct ldb_message *filtered_msg)
 {
-       unsigned int i;
+       unsigned int i = 0;
        bool keep_all = false;
        bool add_dn = false;
        uint32_t num_elements;