irqchip/sifive-plic: Avoid explicit cpumask allocation on stack

In general it's preferable to avoid placing cpumasks on the stack, as
for large values of NR_CPUS these can consume significant amounts of
stack space and make stack overflows more likely.

Use cpumask_first_and_and() to avoid the need for a temporary cpumask on
the stack.

Signed-off-by: Dawei Li <dawei.li@shingroup.cn>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Anup Patel <anup@brainfault.org>
Link: https://lore.kernel.org/r/20240416085454.3547175-7-dawei.li@shingroup.cn

diff --git a/drivers/irqchip/irq-sifive-plic.c b/drivers/irqchip/irq-sifive-plic.c
index f3d4cb9e34f7d8b824ad4fbb8e2e9b10b71232d2..8fb183ced1e7781a00e6eac880481e198d60843f 100644 (file)
--- a/drivers/irqchip/irq-sifive-plic.c
+++ b/drivers/irqchip/irq-sifive-plic.c
@@ -164,15 +164,12 @@ static int plic_set_affinity(struct irq_data *d,
                             const struct cpumask *mask_val, bool force)
 {
        unsigned int cpu;
-       struct cpumask amask;
        struct plic_priv *priv = irq_data_get_irq_chip_data(d);
 
-       cpumask_and(&amask, &priv->lmask, mask_val);
-
        if (force)
-               cpu = cpumask_first(&amask);
+               cpu = cpumask_first_and(&priv->lmask, mask_val);
        else
-               cpu = cpumask_any_and(&amask, cpu_online_mask);
+               cpu = cpumask_first_and_and(&priv->lmask, mask_val, cpu_online_mask);
 
        if (cpu >= nr_cpu_ids)
                return -EINVAL;