]> git.ipfire.org Git - thirdparty/squid.git/commitdiff
Complain about malformed 64bit header values, not the valid ones.
authorAlex Rousskov <rousskov@measurement-factory.com>
Wed, 25 Jan 2017 22:29:03 +0000 (15:29 -0700)
committerAlex Rousskov <rousskov@measurement-factory.com>
Wed, 25 Jan 2017 22:29:03 +0000 (15:29 -0700)
I added this regression in r14819, apparently confused by my own
unfortunate "bad is true" httpHeaderNoteParsedEntry(error) API.

src/HttpHeader.cc

index 8b5fdb8543ff67e02709c87d4b97c8d51cfb5f82..85f5126b7c47050aee3af6e55c005b63afd1da9b 100644 (file)
@@ -1513,7 +1513,7 @@ HttpHeaderEntry::getInt64() const
 {
     int64_t val = -1;
     const bool ok = httpHeaderParseOffset(value.termedBuf(), &val);
-    httpHeaderNoteParsedEntry(id, value, ok);
+    httpHeaderNoteParsedEntry(id, value, !ok);
     return val; // remains -1 if !ok (XXX: bad method API)
 }