debuginfod: only update database stats once per groom

On very large servers, each database-stat counting pass can take tens
of minutes (!), and doing it twice per groom pass does not seriously
improve data quality.  Just do it once, after stale data removal &
basic sqlite vacuum.

Signed-off-by: Frank Ch. Eigler <fche@redhat.com>

diff --git a/debuginfod/ChangeLog b/debuginfod/ChangeLog
index 3bd2ff606aa6745b0649bba085b5c6b65610975b..ed2f77cfaece5140b83519a952ffcec530b6516b 100644 (file)
--- a/debuginfod/ChangeLog
+++ b/debuginfod/ChangeLog
@@ -1,3 +1,7 @@
+2021-04-15  Frank Ch. Eigler <fche@redhat.com>
+
+       * debuginfod.cxx (groom): Only update database stats once.
+
 2021-04-15  Frank Ch. Eigler <fche@redhat.com>
 
        * debuginfod.cxx (elf_classify): Recognize symtab-only stripped files

diff --git a/debuginfod/debuginfod.cxx b/debuginfod/debuginfod.cxx
index 2d73a136ae5e8eb49c29ca3d995f387bdcacece4..50777f1fa1936a5776117c3f4179c221eae53145 100644 (file)
--- a/debuginfod/debuginfod.cxx
+++ b/debuginfod/debuginfod.cxx
@@ -3100,8 +3100,6 @@ void groom()
   struct timespec ts_start, ts_end;
   clock_gettime (CLOCK_MONOTONIC, &ts_start);
 
-  database_stats_report();
-
   // scan for files that have disappeared
   sqlite_ps files (db, "check old files", "select s.mtime, s.file, f.name from "
                        BUILDIDS "_file_mtime_scanned s, " BUILDIDS "_files f "