]> git.ipfire.org Git - thirdparty/kernel/stable-queue.git/commitdiff
3.18-stable patches
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 29 Apr 2018 10:21:16 +0000 (12:21 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 29 Apr 2018 10:21:16 +0000 (12:21 +0200)
added patches:
ext4-set-h_journal-if-there-is-a-failure-starting-a-reserved-handle.patch

queue-3.18/ext4-set-h_journal-if-there-is-a-failure-starting-a-reserved-handle.patch [new file with mode: 0644]
queue-3.18/series [new file with mode: 0644]
queue-4.14/series [new file with mode: 0644]
queue-4.16/series [new file with mode: 0644]
queue-4.4/series [new file with mode: 0644]
queue-4.9/series [new file with mode: 0644]

diff --git a/queue-3.18/ext4-set-h_journal-if-there-is-a-failure-starting-a-reserved-handle.patch b/queue-3.18/ext4-set-h_journal-if-there-is-a-failure-starting-a-reserved-handle.patch
new file mode 100644 (file)
index 0000000..8939b34
--- /dev/null
@@ -0,0 +1,43 @@
+From b2569260d55228b617bd82aba6d0db2faeeb4116 Mon Sep 17 00:00:00 2001
+From: Theodore Ts'o <tytso@mit.edu>
+Date: Wed, 18 Apr 2018 11:49:31 -0400
+Subject: ext4: set h_journal if there is a failure starting a reserved handle
+
+From: Theodore Ts'o <tytso@mit.edu>
+
+commit b2569260d55228b617bd82aba6d0db2faeeb4116 upstream.
+
+If ext4 tries to start a reserved handle via
+jbd2_journal_start_reserved(), and the journal has been aborted, this
+can result in a NULL pointer dereference.  This is because the fields
+h_journal and h_transaction in the handle structure share the same
+memory, via a union, so jbd2_journal_start_reserved() will clear
+h_journal before calling start_this_handle().  If this function fails
+due to an aborted handle, h_journal will still be NULL, and the call
+to jbd2_journal_free_reserved() will pass a NULL journal to
+sub_reserve_credits().
+
+This can be reproduced by running "kvm-xfstests -c dioread_nolock
+generic/475".
+
+Cc: stable@kernel.org # 3.11
+Fixes: 8f7d89f36829b ("jbd2: transaction reservation support")
+Signed-off-by: Theodore Ts'o <tytso@mit.edu>
+Reviewed-by: Andreas Dilger <adilger@dilger.ca>
+Reviewed-by: Jan Kara <jack@suse.cz>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+
+---
+ fs/jbd2/transaction.c |    1 +
+ 1 file changed, 1 insertion(+)
+
+--- a/fs/jbd2/transaction.c
++++ b/fs/jbd2/transaction.c
+@@ -515,6 +515,7 @@ int jbd2_journal_start_reserved(handle_t
+        */
+       ret = start_this_handle(journal, handle, GFP_NOFS);
+       if (ret < 0) {
++              handle->h_journal = journal;
+               jbd2_journal_free_reserved(handle);
+               return ret;
+       }
diff --git a/queue-3.18/series b/queue-3.18/series
new file mode 100644 (file)
index 0000000..60ba5a2
--- /dev/null
@@ -0,0 +1 @@
+ext4-set-h_journal-if-there-is-a-failure-starting-a-reserved-handle.patch
diff --git a/queue-4.14/series b/queue-4.14/series
new file mode 100644 (file)
index 0000000..d4dec00
--- /dev/null
@@ -0,0 +1,3 @@
+ext4-prevent-right-shifting-extents-beyond-ext_max_blocks.patch
+ext4-set-h_journal-if-there-is-a-failure-starting-a-reserved-handle.patch
+ext4-add-module_softdep-to-ensure-crc32c-is-included-in-the-initramfs.patch
diff --git a/queue-4.16/series b/queue-4.16/series
new file mode 100644 (file)
index 0000000..d4dec00
--- /dev/null
@@ -0,0 +1,3 @@
+ext4-prevent-right-shifting-extents-beyond-ext_max_blocks.patch
+ext4-set-h_journal-if-there-is-a-failure-starting-a-reserved-handle.patch
+ext4-add-module_softdep-to-ensure-crc32c-is-included-in-the-initramfs.patch
diff --git a/queue-4.4/series b/queue-4.4/series
new file mode 100644 (file)
index 0000000..20861ac
--- /dev/null
@@ -0,0 +1,2 @@
+ext4-prevent-right-shifting-extents-beyond-ext_max_blocks.patch
+ext4-set-h_journal-if-there-is-a-failure-starting-a-reserved-handle.patch
diff --git a/queue-4.9/series b/queue-4.9/series
new file mode 100644 (file)
index 0000000..20861ac
--- /dev/null
@@ -0,0 +1,2 @@
+ext4-prevent-right-shifting-extents-beyond-ext_max_blocks.patch
+ext4-set-h_journal-if-there-is-a-failure-starting-a-reserved-handle.patch