]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
objtool: Remove redundant opts.noinstr dependency
authorJosh Poimboeuf <jpoimboe@kernel.org>
Mon, 24 Mar 2025 21:56:03 +0000 (14:56 -0700)
committerIngo Molnar <mingo@kernel.org>
Tue, 25 Mar 2025 08:20:28 +0000 (09:20 +0100)
The --noinstr dependecy on --link is already enforced in the cmdline arg
parsing code.  Remove the redundant check.

Signed-off-by: Josh Poimboeuf <jpoimboe@kernel.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Link: https://lore.kernel.org/r/0ead7ffa0f5be2e81aebbcc585e07b2c98702b44.1742852847.git.jpoimboe@kernel.org
tools/objtool/check.c

index ac21f2846ebc06b9e31457fc7e04997f6e8adbb6..0caabf0e8faf2cdafd4afd4aea2d2bb9e759e043 100644 (file)
@@ -340,12 +340,7 @@ static void init_insn_state(struct objtool_file *file, struct insn_state *state,
        memset(state, 0, sizeof(*state));
        init_cfi_state(&state->cfi);
 
-       /*
-        * We need the full vmlinux for noinstr validation, otherwise we can
-        * not correctly determine insn_call_dest(insn)->sec (external symbols
-        * do not have a section).
-        */
-       if (opts.link && opts.noinstr && sec)
+       if (opts.noinstr && sec)
                state->noinstr = sec->noinstr;
 }