Fix a small coverity issue in lmdb backend and fix a compiler warning

diff --git a/modules/lmdbbackend/lmdbbackend.cc b/modules/lmdbbackend/lmdbbackend.cc
index 0f26c38e651349ddbdd2d34adf6769895ff54102..adccc89d351d73a1b9389a4587f273d30c9207f9 100644 (file)
--- a/modules/lmdbbackend/lmdbbackend.cc
+++ b/modules/lmdbbackend/lmdbbackend.cc
@@ -238,7 +238,7 @@ std::string serToString(const vector<DNSResourceRecord>& rrs)
   return ret;
 }
 
-size_t serOneRRFromString(const string_view& str, DNSResourceRecord& rr)
+static inline size_t serOneRRFromString(const string_view& str, DNSResourceRecord& rr)
 {
   uint16_t len;
   memcpy(&len, &str[0], 2);
@@ -546,8 +546,8 @@ bool LMDBBackend::upgradeToSchemav3()
 {
   for(auto i = 0; i < d_shards; i++) {
     string filename = getArg("filename")+"-"+std::to_string(i);
-    if (!access(filename.c_str(), F_OK)) {
-      rename(filename.c_str(), (filename+"-old").c_str());
+    if (rename(filename.c_str(), (filename+"-old").c_str()) < 0) {
+        unixDie("Rename failed during LMDB upgrade");
     }
 
     LMDBBackend::RecordsDB oldShard, newShard;