]> git.ipfire.org Git - thirdparty/shadow.git/commitdiff
commonio: free removed database entries
authorChristian Göttsche <cgzones@googlemail.com>
Sat, 1 Apr 2023 11:36:51 +0000 (13:36 +0200)
committerSerge Hallyn <serge@hallyn.com>
Wed, 26 Apr 2023 22:52:54 +0000 (17:52 -0500)
Free the actual struct of the removed entry.

Example userdel report:

    Direct leak of 40 byte(s) in 1 object(s) allocated from:
        #0 0x55b230efe857 in reallocarray (./src/userdel+0xda857)
        #1 0x55b230f6041f in mallocarray ./lib/./alloc.h:97:9
        #2 0x55b230f6041f in commonio_open ./lib/commonio.c:563:7
        #3 0x55b230f39098 in open_files ./src/userdel.c:555:6
        #4 0x55b230f39098 in main ./src/userdel.c:1189:2
        #5 0x7f9b48c64189 in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16

lib/commonio.c

index 40e6229871eebff341a3eeeed8997663fb0746e6..a0449c83a86e023b52b6c50caa9762750117f369 100644 (file)
@@ -1060,6 +1060,8 @@ int commonio_remove (struct commonio_db *db, const char *name)
                db->ops->free (p->eptr);
        }
 
+       free(p);
+
        return 1;
 }