]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
pinctrl: sunxi: use kcalloc() instead of kzalloc()
authorQianfeng Rong <rongqianfeng@vivo.com>
Tue, 19 Aug 2025 14:39:35 +0000 (22:39 +0800)
committerLinus Walleij <linus.walleij@linaro.org>
Thu, 21 Aug 2025 11:28:50 +0000 (13:28 +0200)
Use devm_kcalloc() in init_pins_table() and prepare_function_table() to
gain built-in overflow protection, making memory allocation safer when
calculating allocation size compared to explicit multiplication.

Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
Acked-by: Chen-Yu Tsai <wens@csie.org>
Link: https://lore.kernel.org/20250819143935.372084-5-rongqianfeng@vivo.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/sunxi/pinctrl-sunxi-dt.c

index 4e34b0cd3b73aad2ba99a9e87d83f5003c32a214..5f13315ebff340283ffb8bcbb8695830d9d714c9 100644 (file)
@@ -103,7 +103,7 @@ static struct sunxi_desc_pin *init_pins_table(struct device *dev,
                return ERR_PTR(-EINVAL);
        }
 
-       pins = devm_kzalloc(dev, desc->npins * sizeof(*pins), GFP_KERNEL);
+       pins = devm_kcalloc(dev, desc->npins, sizeof(*pins), GFP_KERNEL);
        if (!pins)
                return ERR_PTR(-ENOMEM);
 
@@ -199,7 +199,7 @@ static int prepare_function_table(struct device *dev, struct device_node *pnode,
         * Allocate the memory needed for the functions in one table.
         * We later use pointers into this table to mark each pin.
         */
-       func = devm_kzalloc(dev, num_funcs * sizeof(*func), GFP_KERNEL);
+       func = devm_kcalloc(dev, num_funcs, sizeof(*func), GFP_KERNEL);
        if (!func)
                return -ENOMEM;