usb: dwc3: st: simplify with dev_err_probe

Use dev_err_probe() to make the error paths a bit simpler.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com>
Acked-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Link: https://lore.kernel.org/r/20240814-b4-cleanup-h-of-node-put-usb-v1-2-95481b9682bc@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/usb/dwc3/dwc3-st.c b/drivers/usb/dwc3/dwc3-st.c
index 98f43d7082d7b0fcc309acf262251fa728b2a828..7a0b1821768aa43745d49a720d0f677996f9749b 100644 (file)
--- a/drivers/usb/dwc3/dwc3-st.c
+++ b/drivers/usb/dwc3/dwc3-st.c
@@ -237,10 +237,9 @@ static int st_dwc3_probe(struct platform_device *pdev)
 
        dwc3_data->rstc_pwrdn =
                devm_reset_control_get_exclusive(dev, "powerdown");
-       if (IS_ERR(dwc3_data->rstc_pwrdn)) {
-               dev_err(&pdev->dev, "could not get power controller\n");
-               return PTR_ERR(dwc3_data->rstc_pwrdn);
-       }
+       if (IS_ERR(dwc3_data->rstc_pwrdn))
+               return dev_err_probe(dev, PTR_ERR(dwc3_data->rstc_pwrdn),
+                                    "could not get power controller\n");
 
        /* Manage PowerDown */
        reset_control_deassert(dwc3_data->rstc_pwrdn);
@@ -248,8 +247,8 @@ static int st_dwc3_probe(struct platform_device *pdev)
        dwc3_data->rstc_rst =
                devm_reset_control_get_shared(dev, "softreset");
        if (IS_ERR(dwc3_data->rstc_rst)) {
-               dev_err(&pdev->dev, "could not get reset controller\n");
-               ret = PTR_ERR(dwc3_data->rstc_rst);
+               ret = dev_err_probe(dev, PTR_ERR(dwc3_data->rstc_rst),
+                                   "could not get reset controller\n");
                goto undo_powerdown;
        }