]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
domain_conf: graphics: extract Desktop formatting to separate function
authorPavel Hrdina <phrdina@redhat.com>
Thu, 6 Mar 2025 11:00:13 +0000 (12:00 +0100)
committerPavel Hrdina <phrdina@redhat.com>
Fri, 7 Mar 2025 13:01:27 +0000 (14:01 +0100)
virDomainGraphicsDefFormat function was way too long so split it into
separate functions for each graphics type.

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
src/conf/domain_conf.c

index 3587abc24a67c885de21c4ad64c8c54b5886b8a1..c66cdfc1a2008e3ed2aaf7b270b7f8f3bf340670 100644 (file)
@@ -26531,6 +26531,16 @@ virDomainGraphicsDefFormatRDP(virBuffer *attrBuf,
     virDomainGraphicsListenDefFormatAddr(attrBuf, glisten, flags);
 }
 
+static void
+virDomainGraphicsDefFormatDesktop(virBuffer *attrBuf,
+                                  virDomainGraphicsDef *def)
+{
+    virBufferEscapeString(attrBuf, " display='%s'", def->data.desktop.display);
+
+    if (def->data.desktop.fullscreen)
+        virBufferAddLit(attrBuf, " fullscreen='yes'");
+}
+
 static int
 virDomainGraphicsDefFormat(virBuffer *buf,
                            virDomainGraphicsDef *def,
@@ -26565,12 +26575,7 @@ virDomainGraphicsDefFormat(virBuffer *buf,
         break;
 
     case VIR_DOMAIN_GRAPHICS_TYPE_DESKTOP:
-        virBufferEscapeString(&attrBuf, " display='%s'",
-                              def->data.desktop.display);
-
-        if (def->data.desktop.fullscreen)
-            virBufferAddLit(&attrBuf, " fullscreen='yes'");
-
+        virDomainGraphicsDefFormatDesktop(&attrBuf, def);
         break;
 
     case VIR_DOMAIN_GRAPHICS_TYPE_SPICE: