]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
i2c: omap: Handle omap_i2c_init() errors in omap_i2c_probe()
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sat, 5 Jul 2025 07:57:37 +0000 (09:57 +0200)
committerAndi Shyti <andi.shyti@kernel.org>
Thu, 10 Jul 2025 09:58:19 +0000 (11:58 +0200)
omap_i2c_init() can fail. Handle this error in omap_i2c_probe().

Fixes: 010d442c4a29 ("i2c: New bus driver for TI OMAP boards")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: <stable@vger.kernel.org> # v2.6.19+
Signed-off-by: Andi Shyti <andi.shyti@kernel.org>
Link: https://lore.kernel.org/r/565311abf9bafd7291ca82bcecb48c1fac1e727b.1751701715.git.christophe.jaillet@wanadoo.fr
drivers/i2c/busses/i2c-omap.c

index 8b01df3cc8e956fe6a90be83cb73226a073c8eb6..17db58195c06ead3b092c4ac96882ecc02a7e841 100644 (file)
@@ -1472,7 +1472,9 @@ omap_i2c_probe(struct platform_device *pdev)
        }
 
        /* reset ASAP, clearing any IRQs */
-       omap_i2c_init(omap);
+       r = omap_i2c_init(omap);
+       if (r)
+               goto err_mux_state_deselect;
 
        if (omap->rev < OMAP_I2C_OMAP1_REV_2)
                r = devm_request_irq(&pdev->dev, omap->irq, omap_i2c_omap1_isr,
@@ -1515,6 +1517,7 @@ omap_i2c_probe(struct platform_device *pdev)
 
 err_unuse_clocks:
        omap_i2c_write_reg(omap, OMAP_I2C_CON_REG, 0);
+err_mux_state_deselect:
        if (omap->mux_state)
                mux_state_deselect(omap->mux_state);
 err_put_pm: