]> git.ipfire.org Git - thirdparty/nftables.git/commitdiff
src: fix obj list output when reset command
authorJose M. Guisado Gomez <guigom@riseup.net>
Sat, 1 Aug 2020 21:30:10 +0000 (23:30 +0200)
committerPablo Neira Ayuso <pablo@netfilter.org>
Mon, 3 Aug 2020 10:59:32 +0000 (12:59 +0200)
This patch enables json output when doing a reset command.

Previously do_list_obj was called at the end of do_command_reset to
list the named object affected by the reset, this function
is for nft output only.

Listing affected objects using do_command_list ensures
output flags will be honored.

Eg: For a ruleset like

table inet x {
counter user123 {
packets 12 bytes 1433
}

counter user321 {
packets 0 bytes 0
}

quota user123 {
over 2000 bytes
}

quota user124 {
over 2000 bytes
}

set y {
type ipv4_addr
}

...
}

{
    "nftables": [
        {
            "metainfo": {
                "json_schema_version": 1,
                "release_name": "Capital Idea #2",
                "version": "0.9.6"
            }
        },
        {
            "counter": {
                "bytes": 0,
                "family": "inet",
                "handle": 3,
                "name": "user321",
                "packets": 0,
                "table": "x"
            }
        },
        {
            "counter": {
                "bytes": 1433,
                "family": "inet",
                "handle": 2,
                "name": "user123",
                "packets": 12,
                "table": "x"
            }
        }
    ]
}

Fixes: https://bugzilla.netfilter.org/show_bug.cgi?id=1336
Signed-off-by: Jose M. Guisado Gomez <guigom@riseup.net>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
src/rule.c

index fed9e1238af131549911ac2765aea2bbfd53ee0f..6335aa2189adcce00e66f8de3c7b036e8396b301 100644 (file)
@@ -2682,7 +2682,7 @@ static int do_command_reset(struct netlink_ctx *ctx, struct cmd *cmd)
        if (ret < 0)
                return ret;
 
-       return do_list_obj(ctx, cmd, type);
+       return do_command_list(ctx, cmd);
 }
 
 static int do_command_flush(struct netlink_ctx *ctx, struct cmd *cmd)