Do not assume that 'char' is signed. Make it explicit.

FossilOrigin-Name: 979da752e6f8767a61a8efed824ffad9605d0f4c

diff --git a/manifest b/manifest
index 36f6559f550aa88b1776e3206bd9536dde8413fd..eea0f83b790455c64035525774105362e733c233 100644 (file)
--- a/manifest
+++ b/manifest
@@ -1,5 +1,5 @@
-C Refactor\sthe\ssqlite3VdbeRecordCompare()\sroutine\sused\sto\scompare\sbtree\srecords.\nCreate\sa\scouple\sof\sfast-track\sroutines\sto\shandle\sthe\scommon\scases\sof\sa\sstring\nwith\sBINARY\scollation\sor\sinteger\svalues\sas\sthe\sleft-most\scolumn.\s\sThis\sgives\na\ssignificant\sperformance\sboost\sin\scommon\suse.
-D 2014-03-03T21:59:33.388
+C Do\snot\sassume\sthat\s'char'\sis\ssigned.\s\sMake\sit\sexplicit.
+D 2014-03-04T00:15:16.875
 F Makefile.arm-wince-mingw32ce-gcc d6df77f1f48d690bd73162294bbba7f59507c72f
 F Makefile.in 2ef13430cd359f7b361bb863504e227b25cc7f81
 F Makefile.linux-gcc 91d710bdc4998cb015f39edf3cb314ec4f4d7e23
@@ -221,7 +221,7 @@ F src/shell.c 7bf07bcacb181ecc3fc3ccacfdfeb4084aee67ed
 F src/sqlite.h.in a2ef671f92747a5a1c8a47bad5c585a8dd9eca80
 F src/sqlite3.rc 11094cc6a157a028b301a9f06b3d03089ea37c3e
 F src/sqlite3ext.h 886f5a34de171002ad46fae8c36a7d8051c190fc
-F src/sqliteInt.h b06500d391d4b7bf4c69fc110e37dd45719b760c
+F src/sqliteInt.h bf529055591dd81ec92a84d35dba0854642f6cc2
 F src/sqliteLimit.h 164b0e6749d31e0daa1a4589a169d31c0dec7b3d
 F src/status.c 7ac05a5c7017d0b9f0b4bcd701228b784f987158
 F src/table.c 2cd62736f845d82200acfa1287e33feb3c15d62e
@@ -1154,8 +1154,7 @@ F tool/vdbe_profile.tcl 67746953071a9f8f2f668b73fe899074e2c6d8c1
 F tool/warnings-clang.sh f6aa929dc20ef1f856af04a730772f59283631d4
 F tool/warnings.sh d1a6de74685f360ab718efda6265994b99bbea01
 F tool/win/sqlite.vsix 030f3eeaf2cb811a3692ab9c14d021a75ce41fff
-P c0fa0c0e2de50d7eda19ab8862496b18eff93538 fcf480cc630976b619aabd5f7fb7b09601a178fb
-R 4042a62ac4c0618104f381105ba13add
-T +closed fcf480cc630976b619aabd5f7fb7b09601a178fb
+P aec5473a750e412eb1e11e17bbafd760db086c86
+R 3fc76904aa4a71ad8f46b000aee0d4b3
 U drh
-Z f2b997d224dae00836e71263e0e4d70e
+Z f6bc4780db4acc20db7127296b21d314

diff --git a/manifest.uuid b/manifest.uuid
index 93e0969edd13268d6dda160c371400f15b00b4bb..0b0b678799df515f8f2daed3d3bf2739657a4712 100644 (file)
--- a/manifest.uuid
+++ b/manifest.uuid
@@ -1 +1 @@
-aec5473a750e412eb1e11e17bbafd760db086c86
\ No newline at end of file
+979da752e6f8767a61a8efed824ffad9605d0f4c
\ No newline at end of file

diff --git a/src/sqliteInt.h b/src/sqliteInt.h
index a368b96c6315c95873c9086777be00f9bef07daa..90e83206ad9e0537215d8d0d4cc6f17067c059fe 100644 (file)
--- a/src/sqliteInt.h
+++ b/src/sqliteInt.h
@@ -1593,7 +1593,7 @@ struct KeyInfo {
 struct UnpackedRecord {
   KeyInfo *pKeyInfo;  /* Collation and sort-order information */
   u16 nField;         /* Number of entries in apMem[] */
-  char default_rc;    /* Comparison result if keys are equal */
+  i8 default_rc;      /* Comparison result if keys are equal */
   Mem *aMem;          /* Values */
   int r1;             /* Value to return if (lhs > rhs) */
   int r2;             /* Value to return if (rhs < lhs) */