]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
context_tracking, rcu: Rename ct_dynticks_cpu() into ct_rcu_watching_cpu()
authorValentin Schneider <vschneid@redhat.com>
Tue, 16 Apr 2024 08:47:14 +0000 (10:47 +0200)
committerNeeraj Upadhyay <neeraj.upadhyay@kernel.org>
Mon, 29 Jul 2024 02:03:10 +0000 (07:33 +0530)
The context_tracking.state RCU_DYNTICKS subvariable has been renamed to
RCU_WATCHING, reflect that change in the related helpers.

Signed-off-by: Valentin Schneider <vschneid@redhat.com>
Reviewed-by: Frederic Weisbecker <frederic@kernel.org>
Signed-off-by: Neeraj Upadhyay <neeraj.upadhyay@kernel.org>
include/linux/context_tracking_state.h
kernel/rcu/tree.c
kernel/rcu/tree_stall.h

index cb90d8c1781041d8bddde3c005dd43756cc26fa1..ad5a06a42b4a0f5f9b5222d58d8b69a0884589eb 100644 (file)
@@ -61,7 +61,7 @@ static __always_inline int ct_rcu_watching(void)
        return atomic_read(this_cpu_ptr(&context_tracking.state)) & CT_RCU_WATCHING_MASK;
 }
 
-static __always_inline int ct_dynticks_cpu(int cpu)
+static __always_inline int ct_rcu_watching_cpu(int cpu)
 {
        struct context_tracking *ct = per_cpu_ptr(&context_tracking, cpu);
 
index 3a2f0325aa4325cc2d0a086636122f77bbf19222..e7f612e9f7e569a489cdb70c7943ac37056f9fd9 100644 (file)
@@ -335,14 +335,14 @@ bool rcu_dynticks_zero_in_eqs(int cpu, int *vp)
        int snap;
 
        // If not quiescent, force back to earlier extended quiescent state.
-       snap = ct_dynticks_cpu(cpu) & ~CT_RCU_WATCHING;
-       smp_rmb(); // Order ->dynticks and *vp reads.
+       snap = ct_rcu_watching_cpu(cpu) & ~CT_RCU_WATCHING;
+       smp_rmb(); // Order CT state and *vp reads.
        if (READ_ONCE(*vp))
                return false;  // Non-zero, so report failure;
-       smp_rmb(); // Order *vp read and ->dynticks re-read.
+       smp_rmb(); // Order *vp read and CT state re-read.
 
        // If still in the same extended quiescent state, we are good!
-       return snap == ct_dynticks_cpu(cpu);
+       return snap == ct_rcu_watching_cpu(cpu);
 }
 
 /*
@@ -4805,7 +4805,7 @@ rcu_boot_init_percpu_data(int cpu)
        rdp->grpmask = leaf_node_cpu_bit(rdp->mynode, cpu);
        INIT_WORK(&rdp->strict_work, strict_work_handler);
        WARN_ON_ONCE(ct->dynticks_nesting != 1);
-       WARN_ON_ONCE(rcu_dynticks_in_eqs(ct_dynticks_cpu(cpu)));
+       WARN_ON_ONCE(rcu_dynticks_in_eqs(ct_rcu_watching_cpu(cpu)));
        rdp->barrier_seq_snap = rcu_state.barrier_sequence;
        rdp->rcu_ofl_gp_seq = rcu_state.gp_seq;
        rdp->rcu_ofl_gp_state = RCU_GP_CLEANED;
index 4b0e9d7c4c68ee029c72d7094c4be7dc3b0d1582..d65974448e8138ae18634d6243820de7aa755c40 100644 (file)
@@ -501,7 +501,7 @@ static void print_cpu_stall_info(int cpu)
        }
        delta = rcu_seq_ctr(rdp->mynode->gp_seq - rdp->rcu_iw_gp_seq);
        falsepositive = rcu_is_gp_kthread_starving(NULL) &&
-                       rcu_dynticks_in_eqs(ct_dynticks_cpu(cpu));
+                       rcu_dynticks_in_eqs(ct_rcu_watching_cpu(cpu));
        rcuc_starved = rcu_is_rcuc_kthread_starving(rdp, &j);
        if (rcuc_starved)
                // Print signed value, as negative values indicate a probable bug.
@@ -515,7 +515,7 @@ static void print_cpu_stall_info(int cpu)
                        rdp->rcu_iw_pending ? (int)min(delta, 9UL) + '0' :
                                "!."[!delta],
               ticks_value, ticks_title,
-              ct_dynticks_cpu(cpu) & 0xffff,
+              ct_rcu_watching_cpu(cpu) & 0xffff,
               ct_dynticks_nesting_cpu(cpu), ct_dynticks_nmi_nesting_cpu(cpu),
               rdp->softirq_snap, kstat_softirqs_cpu(RCU_SOFTIRQ, cpu),
               data_race(rcu_state.n_force_qs) - rcu_state.n_force_qs_gpstart,