]> git.ipfire.org Git - thirdparty/kernel/stable-queue.git/commitdiff
.27 patches
authorGreg Kroah-Hartman <gregkh@suse.de>
Wed, 4 Aug 2010 22:49:34 +0000 (15:49 -0700)
committerGreg Kroah-Hartman <gregkh@suse.de>
Wed, 4 Aug 2010 22:49:34 +0000 (15:49 -0700)
queue-2.6.27/series
queue-2.6.27/xfs-prevent-swapext-from-operating-on-write-only-files.patch [new file with mode: 0644]

index 323477b71031e0cc9b84b9c82e6b289f0383e8b9..cdd7ef041b67b9e9c61c3696078955626f159fb4 100644 (file)
@@ -1 +1,2 @@
 parisc-led.c-fix-potential-stack-overflow-in-led_proc_write.patch
+xfs-prevent-swapext-from-operating-on-write-only-files.patch
diff --git a/queue-2.6.27/xfs-prevent-swapext-from-operating-on-write-only-files.patch b/queue-2.6.27/xfs-prevent-swapext-from-operating-on-write-only-files.patch
new file mode 100644 (file)
index 0000000..2a284a2
--- /dev/null
@@ -0,0 +1,43 @@
+From 1817176a86352f65210139d4c794ad2d19fc6b63 Mon Sep 17 00:00:00 2001
+From: Dan Rosenberg <dan.j.rosenberg@gmail.com>
+Date: Thu, 24 Jun 2010 12:07:47 +1000
+Subject: xfs: prevent swapext from operating on write-only files
+
+From: Dan Rosenberg <dan.j.rosenberg@gmail.com>
+
+commit 1817176a86352f65210139d4c794ad2d19fc6b63 upstream.
+
+This patch prevents user "foo" from using the SWAPEXT ioctl to swap
+a write-only file owned by user "bar" into a file owned by "foo" and
+subsequently reading it.  It does so by checking that the file
+descriptors passed to the ioctl are also opened for reading.
+
+Signed-off-by: Dan Rosenberg <dan.j.rosenberg@gmail.com>
+Reviewed-by: Christoph Hellwig <hch@lst.de>
+Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
+
+---
+ fs/xfs/xfs_dfrag.c |    5 ++++-
+ 1 file changed, 4 insertions(+), 1 deletion(-)
+
+--- a/fs/xfs/xfs_dfrag.c
++++ b/fs/xfs/xfs_dfrag.c
+@@ -74,7 +74,9 @@ xfs_swapext(
+               goto out_free_sxp;
+       }
+-      if (!(file->f_mode & FMODE_WRITE) || (file->f_flags & O_APPEND)) {
++      if (!(file->f_mode & FMODE_WRITE) ||
++          !(file->f_mode & FMODE_READ) ||
++          (file->f_flags & O_APPEND)) {
+               error = XFS_ERROR(EBADF);
+               goto out_put_file;
+       }
+@@ -86,6 +88,7 @@ xfs_swapext(
+       }
+       if (!(target_file->f_mode & FMODE_WRITE) ||
++          !(target_file->f_mode & FMODE_READ) ||
+           (target_file->f_flags & O_APPEND)) {
+               error = XFS_ERROR(EBADF);
+               goto out_put_target_file;