Remove some useless logs from the TAP tests of pgbench

002_pgbench_no_server was printing some array pointers instead of the
actual contents of those arrays for the expected outputs of stdout and
stderr for a tested command.  This does not add any new information that
can help with debugging as the test names allow to track failure
locations, if any.

This commit simply removes those logs as the rest of the printed
information is redundant with command_checks_all().

Per discussion with Andrew Dunstan and Álvaro Herrera.

Discussion: https://postgr.es/m/YNXNFaG7IgkzZanD@paquier.xyz
Backpatch-through: 11

diff --git a/src/bin/pgbench/t/002_pgbench_no_server.pl b/src/bin/pgbench/t/002_pgbench_no_server.pl
index 69a6d03bb3f8ffe5e12990eb4b218742ce44751a..a2d5c93956914835cbe5c9dfa1aa0d0aee517b26 100644 (file)
--- a/src/bin/pgbench/t/002_pgbench_no_server.pl
+++ b/src/bin/pgbench/t/002_pgbench_no_server.pl
@@ -23,7 +23,6 @@ sub pgbench
        local $Test::Builder::Level = $Test::Builder::Level + 1;
 
        my ($opts, $stat, $out, $err, $name) = @_;
-       print STDERR "opts=$opts, stat=$stat, out=$out, err=$err, name=$name";
        command_checks_all([ 'pgbench', split(/\s+/, $opts) ],
                $stat, $out, $err, $name);
        return;