]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
megaraid_sas: don't set QUEUE_FLAG_NOMERGES
authorChristoph Hellwig <hch@lst.de>
Thu, 27 Jun 2024 12:49:12 +0000 (14:49 +0200)
committerJens Axboe <axboe@kernel.dk>
Fri, 28 Jun 2024 16:37:34 +0000 (10:37 -0600)
Setting QUEUE_FLAG_NOMERGES was added in commit 15dd03811d99dcf
("scsi: megaraid_sas: NVME Interface detection and prop settings")
without any explanation.  Drivers should second guess the block
layer merge decisions, so remove the flag.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20240627124926.512662-3-hch@lst.de
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/scsi/megaraid/megaraid_sas_base.c

index 88acefbf9aeabacf7c93e87c72f268e3102dab68..6c79c350a4d5ba7e7e8c4aa8c21ec11dd9fa5b26 100644 (file)
@@ -1981,8 +1981,6 @@ megasas_set_nvme_device_properties(struct scsi_device *sdev,
 
        lim->max_hw_sectors = max_io_size / 512;
        lim->virt_boundary_mask = mr_nvme_pg_size - 1;
-
-       blk_queue_flag_set(QUEUE_FLAG_NOMERGES, sdev->request_queue);
 }
 
 /*