]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
media: iris: Remove unnecessary re-initialization of flush completion
authorDikshita Agarwal <quic_dikshita@quicinc.com>
Fri, 9 May 2025 08:39:02 +0000 (14:09 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 28 Aug 2025 14:34:29 +0000 (16:34 +0200)
commit b7a898184e74a8261c34f1265139ac1799ee4e1c upstream.

Currently, The flush completion signal is being re-initialized even
though no response is expected during a sequence change.

Simplify the code by removing re-initialization of flush completion
signal as it is redundant.

Cc: stable@vger.kernel.org
Fixes: 84e17adae3e3 ("media: iris: add support for dynamic resolution change")
Acked-by: Vikash Garodia <quic_vgarodia@quicinc.com>
Tested-by: Neil Armstrong <neil.armstrong@linaro.org> # on SM8550-QRD
Tested-by: Neil Armstrong <neil.armstrong@linaro.org> # on SM8550-HDK
Tested-by: Neil Armstrong <neil.armstrong@linaro.org> # on SM8650-QRD
Tested-by: Neil Armstrong <neil.armstrong@linaro.org> # on SM8650-HDK
Signed-off-by: Dikshita Agarwal <quic_dikshita@quicinc.com>
Tested-by: Vikash Garodia <quic_vgarodia@quicinc.com> # on sa8775p-ride
Signed-off-by: Bryan O'Donoghue <bod@kernel.org>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/media/platform/qcom/iris/iris_hfi_gen1_response.c

index 56f5e9e30bc616ef88c06cf5db8141ede60e5e09..14d8bef62b606acaee514d986eba2f213d1d8c9a 100644 (file)
@@ -201,7 +201,6 @@ static void iris_hfi_gen1_event_seq_changed(struct iris_inst *inst,
        iris_hfi_gen1_read_changed_params(inst, pkt);
 
        if (inst->state != IRIS_INST_ERROR && !(inst->sub_state & IRIS_INST_SUB_FIRST_IPSC)) {
-               reinit_completion(&inst->flush_completion);
 
                flush_pkt.shdr.hdr.size = sizeof(struct hfi_session_flush_pkt);
                flush_pkt.shdr.hdr.pkt_type = HFI_CMD_SESSION_FLUSH;