]> git.ipfire.org Git - thirdparty/dovecot/core.git/commitdiff
director: Fix potential panic when director is alone
authorTimo Sirainen <timo.sirainen@dovecot.fi>
Thu, 5 Oct 2017 13:12:38 +0000 (16:12 +0300)
committerTimo Sirainen <timo.sirainen@dovecot.fi>
Thu, 5 Oct 2017 13:12:38 +0000 (16:12 +0300)
If director is alone and it can't connect to other directors, it might crash
with:

Panic: file director.c: line 318 (director_set_ring_synced): assertion failed: (!dir->ring_synced)

src/director/director.c

index 650fa05d9d5fba065bd94e830651ce784430bc68..f80f3e361471a6eb42666384db8e07fdf2d9b18a 100644 (file)
@@ -272,7 +272,7 @@ void director_connect(struct director *dir, const char *reason)
        dir->ring_min_version = DIRECTOR_VERSION_MINOR;
        if (!dir->ring_handshaked)
                director_set_ring_handshaked(dir);
-       else
+       else if (!dir->ring_synced)
                director_set_ring_synced(dir);
 }