]> git.ipfire.org Git - thirdparty/squid.git/commitdiff
digest_ldap_auth: Fix crash on empty password
authorAmos Jeffries <squid3@treenet.co.nz>
Fri, 16 Nov 2012 04:08:22 +0000 (21:08 -0700)
committerAmos Jeffries <squid3@treenet.co.nz>
Fri, 16 Nov 2012 04:08:22 +0000 (21:08 -0700)
 Detected by Coverity Scan. Issue 740399

helpers/digest_auth/LDAP/ldap_backend.cc

index 46409866efe861ee429f5b64dc395ad6d3e42271..ec50e7bb7bdf17723ceb09aecc61d0c4ede6abff 100644 (file)
@@ -263,7 +263,8 @@ retrydnattr:
             value = values;
             while (*value) {
                 if (encrpass) {
-                    if (strcmp(strtok(*value, delimiter), realm) == 0) {
+                    const char *t = strtok(*value, delimiter);
+                    if (t && strcmp(t, realm) == 0) {
                         password = strtok(NULL, delimiter);
                         break;
                     }