]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
staging: rtl8723bs: remove unused efuseValue from efuse_OneByteWrite()
authorPing-Ke Shih <pkshih@realtek.com>
Fri, 13 Sep 2024 00:28:13 +0000 (08:28 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 13 Sep 2024 05:31:55 +0000 (07:31 +0200)
The efuseValue is to store value from register EFUSE_CTRL, and set control
bits including address and write bit. This is no need for RTL8723BS, so
the consumer has been removed. Thus, remove these unused codes are safe.

Otherwiese, clang warns:

rtw_efuse.c:285:6: warning:
 variable 'efuseValue' set but not used [-Wunused-but-set-variable]
  285 |         u32 efuseValue;
      |             ^

Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/20240913002815.5149-3-pkshih@realtek.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8723bs/core/rtw_efuse.c

index 6419638c6e207910e89a920ee9958ba74c795be1..8b671f8a79659f106fd13faf1b3e5a44b9c37cb7 100644 (file)
@@ -281,22 +281,13 @@ u8 efuse_OneByteWrite(struct adapter *padapter, u16 addr, u8 data, bool bPseudoT
 {
        u8 tmpidx = 0;
        u8 bResult = false;
-       u32 efuseValue;
 
        if (bPseudoTest)
                return Efuse_Write1ByteToFakeContent(addr, data);
 
-
        /*  -----------------e-fuse reg ctrl --------------------------------- */
        /* address */
 
-
-       efuseValue = rtw_read32(padapter, EFUSE_CTRL);
-       efuseValue |= (BIT21 | BIT31);
-       efuseValue &= ~(0x3FFFF);
-       efuseValue |= ((addr << 8 | data) & 0x3FFFF);
-
-
        /*  <20130227, Kordan> 8192E MP chip A-cut had better not set 0x34[11] until B-Cut. */
 
        /*  <20130121, Kordan> For SMIC EFUSE specificatoin. */