]> git.ipfire.org Git - thirdparty/xfsprogs-dev.git/commitdiff
mkfs.xfs: prevent close(-1) on protofile error path
authorEric Sandeen <sandeen@sandeen.net>
Thu, 1 May 2014 23:32:59 +0000 (09:32 +1000)
committerDave Chinner <david@fromorbit.com>
Thu, 1 May 2014 23:32:59 +0000 (09:32 +1000)
My previous cleanups introduced this; in the case where
fd=open() failed, the out_fail: path would try to close(-1).

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Mark Tinguely <tinguely@sgi.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
mkfs/proto.c

index 308325be2f450777a4e241f2e19f161b2abeaf5e..5a47e27c0236c116d6314ba92bdf01841e8da862 100644 (file)
@@ -84,7 +84,8 @@ setup_proto(
        return buf;
 
 out_fail:
-       close(fd);
+       if (fd >= 0)
+               close(fd);
        free(buf);
        exit(1);
 }