]> git.ipfire.org Git - thirdparty/curl.git/commitdiff
cf-h1-proxy: skip an extra NULL assign
authorDaniel Stenberg <daniel@haxx.se>
Thu, 13 Apr 2023 10:50:04 +0000 (12:50 +0200)
committerDaniel Stenberg <daniel@haxx.se>
Thu, 13 Apr 2023 15:23:50 +0000 (17:23 +0200)
and use Curl_safefree() once to save another NULL assign. Found by PVS.

Ref. #10929
Closes #10953

lib/cf-h1-proxy.c

index a02c46a52696625189efafa2521eb777263c3009..700c199b1add45a251f1dc4e0d96e33c138aa872 100644 (file)
@@ -215,7 +215,6 @@ static void tunnel_go_state(struct Curl_cfilter *cf,
        make sure that it isn't accidentally used for the document request
        after we've connected. So let's free and clear it here. */
     Curl_safefree(data->state.aptr.proxyuserpwd);
-    data->state.aptr.proxyuserpwd = NULL;
 #ifdef USE_HYPER
     data->state.hconnect = FALSE;
 #endif
@@ -1043,8 +1042,7 @@ static CURLcode CONNECT(struct Curl_cfilter *cf,
   DEBUGASSERT(ts->tunnel_state == TUNNEL_RESPONSE);
   if(data->info.httpproxycode/100 != 2) {
     /* a non-2xx response and we have no next url to try. */
-    free(data->req.newurl);
-    data->req.newurl = NULL;
+    Curl_safefree(data->req.newurl);
     /* failure, close this connection to avoid re-use */
     streamclose(conn, "proxy CONNECT failure");
     tunnel_go_state(cf, ts, TUNNEL_FAILED, data);