scsi: megaraid_sas: Block zero-length ATA VPD inquiry

A firmware bug was observed where ATA VPD inquiry commands with a
zero-length data payload were not handled and failed with a non-standard
status code of 0xf0.

Avoid sending ATA VPD inquiry commands without data payload by setting
the device no_vpd_size flag to 1. In addition, if the firmware returns a
status code of 0xf0, set scsi_cmnd->result to CHECK_CONDITION to
facilitate proper error handling.

Suggested-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Chandrakanth Patil <chandrakanth.patil@broadcom.com>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20250402193735.5098-1-chandrakanth.patil@broadcom.com
Tested-by: Ryan Lahfa <ryan@lahfa.xyz>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c
index 28c75865967af36c6390c5ee5767577ec1bcf779..d793924547f80ee8049a7c97ea820589afc10e34 100644 (file)
--- a/drivers/scsi/megaraid/megaraid_sas_base.c
+++ b/drivers/scsi/megaraid/megaraid_sas_base.c
@@ -2103,6 +2103,9 @@ static int megasas_sdev_configure(struct scsi_device *sdev,
        /* This sdev property may change post OCR */
        megasas_set_dynamic_target_properties(sdev, lim, is_target_prop);
 
+       if (!MEGASAS_IS_LOGICAL(sdev))
+               sdev->no_vpd_size = 1;
+
        mutex_unlock(&instance->reset_mutex);
 
        return 0;
@@ -3662,8 +3665,10 @@ megasas_complete_cmd(struct megasas_instance *instance, struct megasas_cmd *cmd,
 
                case MFI_STAT_SCSI_IO_FAILED:
                case MFI_STAT_LD_INIT_IN_PROGRESS:
-                       cmd->scmd->result =
-                           (DID_ERROR << 16) | hdr->scsi_status;
+                       if (hdr->scsi_status == 0xf0)
+                               cmd->scmd->result = (DID_ERROR << 16) | SAM_STAT_CHECK_CONDITION;
+                       else
+                               cmd->scmd->result = (DID_ERROR << 16) | hdr->scsi_status;
                        break;
 
                case MFI_STAT_SCSI_DONE_WITH_ERROR:

diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c b/drivers/scsi/megaraid/megaraid_sas_fusion.c
index 1eec23da28e2d63f5a00f8e5e9d10d2a53c93579..1eea4df9e47d35d0bd800786701a9c279d7eb0a8 100644 (file)
--- a/drivers/scsi/megaraid/megaraid_sas_fusion.c
+++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c
@@ -2043,7 +2043,10 @@ map_cmd_status(struct fusion_context *fusion,
 
        case MFI_STAT_SCSI_IO_FAILED:
        case MFI_STAT_LD_INIT_IN_PROGRESS:
-               scmd->result = (DID_ERROR << 16) | ext_status;
+               if (ext_status == 0xf0)
+                       scmd->result = (DID_ERROR << 16) | SAM_STAT_CHECK_CONDITION;
+               else
+                       scmd->result = (DID_ERROR << 16) | ext_status;
                break;
 
        case MFI_STAT_SCSI_DONE_WITH_ERROR: