]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
powerpc: Fix struct termio related ioctl macros
authorMadhavan Srinivasan <maddy@linux.ibm.com>
Sat, 17 May 2025 14:22:37 +0000 (19:52 +0530)
committerMadhavan Srinivasan <maddy@linux.ibm.com>
Fri, 13 Jun 2025 16:48:50 +0000 (22:18 +0530)
Since termio interface is now obsolete, include/uapi/asm/ioctls.h
has some constant macros referring to "struct termio", this caused
build failure at userspace.

In file included from /usr/include/asm/ioctl.h:12,
                 from /usr/include/asm/ioctls.h:5,
                 from tst-ioctls.c:3:
tst-ioctls.c: In function 'get_TCGETA':
tst-ioctls.c:12:10: error: invalid application of 'sizeof' to incomplete type 'struct termio'
   12 |   return TCGETA;
      |          ^~~~~~

Even though termios.h provides "struct termio", trying to juggle definitions around to
make it compile could introduce regressions. So better to open code it.

Reported-by: Tulio Magno <tuliom@ascii.art.br>
Suggested-by: Nicholas Piggin <npiggin@gmail.com>
Tested-by: Justin M. Forbes <jforbes@fedoraproject.org>
Reviewed-by: Michael Ellerman <mpe@ellerman.id.au>
Closes: https://lore.kernel.org/linuxppc-dev/8734dji5wl.fsf@ascii.art.br/
Signed-off-by: Madhavan Srinivasan <maddy@linux.ibm.com>
Link: https://patch.msgid.link/20250517142237.156665-1-maddy@linux.ibm.com
arch/powerpc/include/uapi/asm/ioctls.h

index 2c145da3b774a136044e9106e96e38559c9e5832..b5211e413829a2d9c299b6ef05d9df92d2a6d4b7 100644 (file)
 #define TCSETSW                _IOW('t', 21, struct termios)
 #define TCSETSF                _IOW('t', 22, struct termios)
 
-#define TCGETA         _IOR('t', 23, struct termio)
-#define TCSETA         _IOW('t', 24, struct termio)
-#define TCSETAW                _IOW('t', 25, struct termio)
-#define TCSETAF                _IOW('t', 28, struct termio)
+#define TCGETA         0x40147417 /* _IOR('t', 23, struct termio) */
+#define TCSETA         0x80147418 /* _IOW('t', 24, struct termio) */
+#define TCSETAW                0x80147419 /* _IOW('t', 25, struct termio) */
+#define TCSETAF                0x8014741c /* _IOW('t', 28, struct termio) */
 
 #define TCSBRK         _IO('t', 29)
 #define TCXONC         _IO('t', 30)