]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
nwfilter: Fix erroneous pointer passing to g_clear_pointer
authorMartin Kletzander <mkletzan@redhat.com>
Wed, 16 Apr 2025 07:38:53 +0000 (09:38 +0200)
committerMartin Kletzander <mkletzan@redhat.com>
Wed, 16 Apr 2025 08:14:39 +0000 (10:14 +0200)
Commit 5de27c32a18f wanted to fix a possible double free, but by mistake
did not pass a reference to the variable.  This made virtnwfilterd
coredump in our daily CI build.

Fixes: 5de27c32a18f1da4969a679a2385d45cf0279699
Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
Reviewed-by: Jiri Denemark <jdenemar@redhat.com>
src/nwfilter/nwfilter_gentech_driver.c

index 0c12b54b802986a80472e9b2a28159b7da72a70b..1465734a54f8ad413b9a1f1bd11d7b1da022b36b 100644 (file)
@@ -203,12 +203,12 @@ virNWFilterInstReset(virNWFilterInst *inst)
 
     for (i = 0; i < inst->nfilters; i++)
         virNWFilterObjUnlock(inst->filters[i]);
-    g_clear_pointer(inst->filters, g_free);
+    g_clear_pointer(&inst->filters, g_free);
     inst->nfilters = 0;
 
     for (i = 0; i < inst->nrules; i++)
         virNWFilterRuleInstFree(inst->rules[i]);
-    g_clear_pointer(inst->rules, g_free);
+    g_clear_pointer(&inst->rules, g_free);
     inst->nrules = 0;
 }