Fix adding and removing datasets in bar samples (#5663)

Account for zero indexing of arrays when creating a name for an added dataset and remove the last dataset in the array when removing a dataset rather than removing the first.

diff --git a/samples/charts/bar/horizontal.html b/samples/charts/bar/horizontal.html
index 6450e014d92064c69c57b1fbb28265d43732fc31..e174ad2ca35cd142955a362a3fd3f17081804a4c 100644 (file)
--- a/samples/charts/bar/horizontal.html
+++ b/samples/charts/bar/horizontal.html
@@ -102,7 +102,7 @@
                        var colorName = colorNames[horizontalBarChartData.datasets.length % colorNames.length];
                        var dsColor = window.chartColors[colorName];
                        var newDataset = {
-                               label: 'Dataset ' + horizontalBarChartData.datasets.length,
+                               label: 'Dataset ' + (horizontalBarChartData.datasets.length + 1),
                                backgroundColor: color(dsColor).alpha(0.5).rgbString(),
                                borderColor: dsColor,
                                data: []
@@ -130,7 +130,7 @@
                });
 
                document.getElementById('removeDataset').addEventListener('click', function() {
-                       horizontalBarChartData.datasets.splice(0, 1);
+                       horizontalBarChartData.datasets.pop();
                        window.myHorizontalBar.update();
                });
 

diff --git a/samples/charts/bar/vertical.html b/samples/charts/bar/vertical.html
index e9348b274fdb9de71265bd23f220f61d76484651..5127d4937c2fc0cf2d05f6a9fafc5a5c92524529 100644 (file)
--- a/samples/charts/bar/vertical.html
+++ b/samples/charts/bar/vertical.html
@@ -95,7 +95,7 @@
                        var colorName = colorNames[barChartData.datasets.length % colorNames.length];
                        var dsColor = window.chartColors[colorName];
                        var newDataset = {
-                               label: 'Dataset ' + barChartData.datasets.length,
+                               label: 'Dataset ' + (barChartData.datasets.length + 1),
                                backgroundColor: color(dsColor).alpha(0.5).rgbString(),
                                borderColor: dsColor,
                                borderWidth: 1,
@@ -125,7 +125,7 @@
                });
 
                document.getElementById('removeDataset').addEventListener('click', function() {
-                       barChartData.datasets.splice(0, 1);
+                       barChartData.datasets.pop();
                        window.myBar.update();
                });