]> git.ipfire.org Git - thirdparty/nftables.git/commitdiff
optimize: incorrect comparison for reject statement
authorPablo Neira Ayuso <pablo@netfilter.org>
Wed, 26 Mar 2025 20:54:04 +0000 (21:54 +0100)
committerPablo Neira Ayuso <pablo@netfilter.org>
Thu, 27 Mar 2025 20:39:03 +0000 (21:39 +0100)
Logic is reverse, this should returns false if the compared reject
expressions are not the same.

Fixes: 38d48fe57fff ("optimize: fix reject statement")
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
src/optimize.c

index 05d8084b2a47564de375dbee72e6940c7a306994..bb849267d8d9fcae767e2f0360104308df30077c 100644 (file)
@@ -235,7 +235,7 @@ static bool __stmt_type_eq(const struct stmt *stmt_a, const struct stmt *stmt_b,
                if (!stmt_a->reject.expr)
                        return true;
 
-               if (__expr_cmp(stmt_a->reject.expr, stmt_b->reject.expr))
+               if (!__expr_cmp(stmt_a->reject.expr, stmt_b->reject.expr))
                        return false;
                break;
        case STMT_NAT: