]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ASoC: simple-card: Drop unnecessary "dai-tdm-slot-width-map" property presence check
authorRob Herring (Arm) <robh@kernel.org>
Thu, 9 Jan 2025 18:22:02 +0000 (12:22 -0600)
committerMark Brown <broonie@kernel.org>
Fri, 10 Jan 2025 15:02:07 +0000 (15:02 +0000)
It doesn't matter whether "dai-tdm-slot-width-map" is not present or
there is some other issue parsing it in of_property_count_elems_of_size()
causing an error. Drop the presence check and rely on
of_property_count_elems_of_size() error return if not present.

Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://patch.msgid.link/20250109182202.3971965-2-robh@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/generic/simple-card-utils.c

index 91325286894ea7f9488ad9d0fcd82b91504f3287..e25b387a97763726bc4cda0803360cc0c350cee7 100644 (file)
@@ -139,10 +139,9 @@ int simple_util_parse_tdm_width_map(struct device *dev, struct device_node *np,
        int n, i, ret;
        u32 *p;
 
-       if (!of_property_read_bool(np, "dai-tdm-slot-width-map"))
-               return 0;
-
        n = of_property_count_elems_of_size(np, "dai-tdm-slot-width-map", sizeof(u32));
+       if (n <= 0)
+               return 0;
        if (n % 3) {
                dev_err(dev, "Invalid number of cells for dai-tdm-slot-width-map\n");
                return -EINVAL;