]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
i3c: master: Fix error return in cdns_i3c_master_probe()
authorJing Xiangfeng <jingxiangfeng@huawei.com>
Fri, 11 Sep 2020 03:33:50 +0000 (11:33 +0800)
committerBoris Brezillon <boris.brezillon@collabora.com>
Wed, 7 Oct 2020 13:14:07 +0000 (15:14 +0200)
Fix to return negative error code -ENOMEM from the error handling
case instead of 0.

Fixes: 603f2bee2c54 ("i3c: master: Add driver for Cadence IP")
Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Link: https://lore.kernel.org/linux-i3c/20200911033350.23904-1-jingxiangfeng@huawei.com
drivers/i3c/master/i3c-master-cdns.c

index 3fee8bd7fe20b57d5699fe953f6dcd1c5a8514bf..3f2226928fe052ba6a3ad213b2630d273a529570 100644 (file)
@@ -1635,8 +1635,10 @@ static int cdns_i3c_master_probe(struct platform_device *pdev)
        master->ibi.slots = devm_kcalloc(&pdev->dev, master->ibi.num_slots,
                                         sizeof(*master->ibi.slots),
                                         GFP_KERNEL);
-       if (!master->ibi.slots)
+       if (!master->ibi.slots) {
+               ret = -ENOMEM;
                goto err_disable_sysclk;
+       }
 
        writel(IBIR_THR(1), master->regs + CMD_IBI_THR_CTRL);
        writel(MST_INT_IBIR_THR, master->regs + MST_IER);