]> git.ipfire.org Git - thirdparty/qemu.git/commitdiff
rust: pl011: match break logic of C version
authorPaolo Bonzini <pbonzini@redhat.com>
Wed, 4 Dec 2024 15:40:29 +0000 (16:40 +0100)
committerPaolo Bonzini <pbonzini@redhat.com>
Thu, 19 Dec 2024 18:36:38 +0000 (19:36 +0100)
Check loopback_enabled(), not fifo_enabled(), like the C code.

Also, set_break_error() must not happen until the break is read from
the FIFO.

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
rust/hw/char/pl011/src/device.rs

index e85d13c5a2b23a98e20dd68f6573757e108a3dd1..960ee38ed69c23696f667e69ac5b763e23c30e41 100644 (file)
@@ -460,9 +460,8 @@ impl PL011State {
     }
 
     pub fn event(&mut self, event: QEMUChrEvent) {
-        if event == bindings::QEMUChrEvent::CHR_EVENT_BREAK && !self.fifo_enabled() {
+        if event == bindings::QEMUChrEvent::CHR_EVENT_BREAK && !self.loopback_enabled() {
             self.put_fifo(DATA_BREAK);
-            self.receive_status_error_clear.set_break_error(true);
         }
     }