]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
RDMA/mlx5: Limit the scope of mlx5_ib_enable_driver function
authorLeon Romanovsky <leonro@mellanox.com>
Thu, 2 Jul 2020 08:18:04 +0000 (11:18 +0300)
committerJason Gunthorpe <jgg@nvidia.com>
Tue, 7 Jul 2020 17:05:51 +0000 (14:05 -0300)
The mlx5_ib_enable_driver() is local function and doesn't need to be
shared in mlx5_ib, so change it's signature to have static keyword in it.

Link: https://lore.kernel.org/r/20200702081809.423482-2-leon@kernel.org
Reviewed-by: Maor Gottlieb <maorg@mellanox.com>
Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
drivers/infiniband/hw/mlx5/main.c
drivers/infiniband/hw/mlx5/mlx5_ib.h

index 2da592054a3f47a511161aeadac4f6039e8922ab..a30c080a1c20adb6aa10ab09d7a0a283f6de2a3d 100644 (file)
@@ -6569,6 +6569,18 @@ static void mlx5_ib_stage_flow_db_cleanup(struct mlx5_ib_dev *dev)
        kfree(dev->flow_db);
 }
 
+static int mlx5_ib_enable_driver(struct ib_device *dev)
+{
+       struct mlx5_ib_dev *mdev = to_mdev(dev);
+       int ret;
+
+       ret = mlx5_ib_test_wc(mdev);
+       mlx5_ib_dbg(mdev, "Write-Combining %s",
+                   mdev->wc_support ? "supported" : "not supported");
+
+       return ret;
+}
+
 static const struct ib_device_ops mlx5_ib_dev_ops = {
        .owner = THIS_MODULE,
        .driver_id = RDMA_DRIVER_MLX5,
@@ -7092,18 +7104,6 @@ static void mlx5_ib_stage_devx_cleanup(struct mlx5_ib_dev *dev)
        }
 }
 
-int mlx5_ib_enable_driver(struct ib_device *dev)
-{
-       struct mlx5_ib_dev *mdev = to_mdev(dev);
-       int ret;
-
-       ret = mlx5_ib_test_wc(mdev);
-       mlx5_ib_dbg(mdev, "Write-Combining %s",
-                   mdev->wc_support ? "supported" : "not supported");
-
-       return ret;
-}
-
 void __mlx5_ib_remove(struct mlx5_ib_dev *dev,
                      const struct mlx5_ib_profile *profile,
                      int stage)
index 88e30ff77c168482104220c702449bb7f756d71f..1f34f64c6f27d12e32271756790bb507f6573462 100644 (file)
@@ -1542,7 +1542,6 @@ static inline bool mlx5_ib_can_use_umr(struct mlx5_ib_dev *dev,
        return true;
 }
 
-int mlx5_ib_enable_driver(struct ib_device *dev);
 int mlx5_ib_test_wc(struct mlx5_ib_dev *dev);
 
 static inline bool mlx5_ib_lag_should_assign_affinity(struct mlx5_ib_dev *dev)