- Fixed ORM bug where the :func:`.class_mapper` function would mask

AttributeErrors or KeyErrors that should raise during mapper
configuration due to user errors.  The catch for attribute/keyerror
has been made more specific to not include the configuration step.
fixes #3047

diff --git a/doc/build/changelog/changelog_08.rst b/doc/build/changelog/changelog_08.rst
index a9d6cc2dab32533ee0ca78344197f7d5c42a96b8..cfbea455c481e6a7f6e44fa5e7ed47f7af4a3d89 100644 (file)
--- a/doc/build/changelog/changelog_08.rst
+++ b/doc/build/changelog/changelog_08.rst
@@ -11,6 +11,16 @@
 .. changelog::
     :version: 0.8.7
 
+    .. change::
+        :tags: bug, orm
+        :tickets: 3047
+        :versions: 0.9.5
+
+        Fixed ORM bug where the :func:`.class_mapper` function would mask
+        AttributeErrors or KeyErrors that should raise during mapper
+        configuration due to user errors.  The catch for attribute/keyerror
+        has been made more specific to not include the configuration step.
+
     .. change::
         :tags: bug, sql
         :tickets: 3045

diff --git a/lib/sqlalchemy/orm/util.py b/lib/sqlalchemy/orm/util.py
index 3a39232a2c5e057cc4be6a1d9c7df1de40e1717b..983ecd57d631785ab1f3a08a817bd23dd15146a1 100644 (file)
--- a/lib/sqlalchemy/orm/util.py
+++ b/lib/sqlalchemy/orm/util.py
@@ -1075,13 +1075,13 @@ def _inspect_mapped_class(class_, configure=False):
         if not class_manager.is_mapped:
             return None
         mapper = class_manager.mapper
+    except exc.NO_STATE:
+        return None
+    else:
         if configure and mapperlib.module._new_mappers:
             mapperlib.configure_mappers()
         return mapper
 
-    except exc.NO_STATE:
-        return None
-
 
 def object_mapper(instance):
     """Given an object, return the primary Mapper associated with the object

diff --git a/test/orm/test_mapper.py b/test/orm/test_mapper.py
index 0ca3480dd35f777e9068372747b7a22a3b82df91..8d10a836b8c0e883f251294be5343d65474e4cd7 100644 (file)
--- a/test/orm/test_mapper.py
+++ b/test/orm/test_mapper.py
@@ -1579,6 +1579,41 @@ class MapperTest(_fixtures.FixtureTest, AssertsCompiledSQL):
             class_mapper, (5, 6)
         )
 
+    def test_attribute_error_raised_class_mapper(self):
+        users = self.tables.users
+        addresses = self.tables.addresses
+        User = self.classes.User
+        Address = self.classes.Address
+
+        mapper(User, users, properties={
+                "addresses": relationship(Address,
+                    primaryjoin=lambda: users.c.id == addresses.wrong.user_id)
+                })
+        mapper(Address, addresses)
+        assert_raises_message(
+            AttributeError,
+            "'Table' object has no attribute 'wrong'",
+            class_mapper, Address
+        )
+
+    def test_key_error_raised_class_mapper(self):
+        users = self.tables.users
+        addresses = self.tables.addresses
+        User = self.classes.User
+        Address = self.classes.Address
+
+        mapper(User, users, properties={
+                "addresses": relationship(Address,
+                    primaryjoin=lambda: users.c.id ==
+                        addresses.__dict__['wrong'].user_id)
+                })
+        mapper(Address, addresses)
+        assert_raises_message(
+            KeyError,
+            "wrong",
+            class_mapper, Address
+        )
+
     def test_unmapped_subclass_error_postmap(self):
         users = self.tables.users