]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
ASoC: atmel: atmel_ssc_dai: Drop S24_LE support due to single channel limitation
authorCodrin Ciubotariu <codrin.ciubotariu@microchip.com>
Mon, 16 Sep 2024 13:19:10 +0000 (16:19 +0300)
committerMark Brown <broonie@kernel.org>
Sun, 29 Sep 2024 23:09:37 +0000 (01:09 +0200)
Drop S24_LE format because it is not supported if more than 2 channels
(of TDM slots) are used. This limitation makes it impractical for use cases
requiring more than 2 TDM slots, leading to potential issues in
multi-channel configurations.

[andrei.simion@microchip.com: Reword the commit title and the commit
message. Add code comment to explain the removed code.]

Signed-off-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
Signed-off-by: Andrei Simion <andrei.simion@microchip.com>
Reviewed-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Link: https://patch.msgid.link/20240916131910.22680-3-andrei.simion@microchip.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/atmel/atmel_ssc_dai.c

index 7047f17fe7a8954d3c4f4cf7b3ee6706a7a88c0a..89098f41679c0a667062bc8edc49f128be0c17fb 100644 (file)
@@ -821,8 +821,9 @@ static int atmel_ssc_resume(struct snd_soc_component *component)
        return 0;
 }
 
+/* S24_LE is not supported if more than 2 channels (of TDM slots) are used. */
 #define ATMEL_SSC_FORMATS (SNDRV_PCM_FMTBIT_S8     | SNDRV_PCM_FMTBIT_S16_LE |\
-                         SNDRV_PCM_FMTBIT_S24_LE | SNDRV_PCM_FMTBIT_S32_LE)
+                          SNDRV_PCM_FMTBIT_S32_LE)
 
 static const struct snd_soc_dai_ops atmel_ssc_dai_ops = {
        .startup        = atmel_ssc_startup,