]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
media: qcom: camss: Add support for TFE (Spectra 340)
authorLoic Poulain <loic.poulain@oss.qualcomm.com>
Tue, 8 Jul 2025 08:32:17 +0000 (10:32 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Tue, 9 Sep 2025 13:59:21 +0000 (15:59 +0200)
Add support for TFE (Thin Front End) found in QCM2290.

Signed-off-by: Loic Poulain <loic.poulain@oss.qualcomm.com>
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
[bod: made tfe_line_iface_map and tfe_subgroup_line map static]
Signed-off-by: Bryan O'Donoghue <bod@kernel.org>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
drivers/media/platform/qcom/camss/Makefile
drivers/media/platform/qcom/camss/camss-vfe-340.c [new file with mode: 0644]
drivers/media/platform/qcom/camss/camss-vfe.h

index d26a9c24a430a831e0d865db4d96142da5276653..719898f5d32b4f2a1755a39021596b5bcfd45022 100644 (file)
@@ -17,6 +17,7 @@ qcom-camss-objs += \
                camss-vfe-4-7.o \
                camss-vfe-4-8.o \
                camss-vfe-17x.o \
+               camss-vfe-340.o \
                camss-vfe-480.o \
                camss-vfe-680.o \
                camss-vfe-780.o \
diff --git a/drivers/media/platform/qcom/camss/camss-vfe-340.c b/drivers/media/platform/qcom/camss/camss-vfe-340.c
new file mode 100644 (file)
index 0000000..55f24eb
--- /dev/null
@@ -0,0 +1,319 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Qualcomm MSM Camera Subsystem - VFE (Video Front End) Module 340 (TFE)
+ *
+ * Copyright (c) 2025 Qualcomm Innovation Center, Inc. All rights reserved.
+ */
+
+#include <linux/delay.h>
+#include <linux/interrupt.h>
+#include <linux/io.h>
+#include <linux/iopoll.h>
+
+#include "camss.h"
+#include "camss-vfe.h"
+
+#define TFE_GLOBAL_RESET_CMD                           (0x014)
+#define                TFE_GLOBAL_RESET_CMD_CORE       BIT(0)
+
+#define TFE_REG_UPDATE_CMD                             (0x02c)
+
+#define TFE_IRQ_CMD                                    (0x030)
+#define                TFE_IRQ_CMD_CLEAR               BIT(0)
+#define TFE_IRQ_MASK_0                                 (0x034)
+#define                TFE_IRQ_MASK_0_RST_DONE         BIT(0)
+#define                TFE_IRQ_MASK_0_BUS_WR           BIT(1)
+#define TFE_IRQ_MASK_1                                 (0x038)
+#define TFE_IRQ_MASK_2                                 (0x03c)
+#define TFE_IRQ_CLEAR_0                                        (0x040)
+
+#define TFE_IRQ_STATUS_0                               (0x04c)
+
+#define BUS_REG(a)                                     (0xa00 + (a))
+
+#define TFE_BUS_IRQ_MASK_0                             BUS_REG(0x18)
+#define                TFE_BUS_IRQ_MASK_RUP_DONE_MASK  GENMASK(3, 0)
+#define                TFE_BUS_IRQ_MASK_RUP_DONE(sc)   FIELD_PREP(TFE_BUS_IRQ_MASK_RUP_DONE_MASK, BIT(sc))
+#define                TFE_BUS_IRQ_MASK_BUF_DONE_MASK  GENMASK(15, 8)
+#define                TFE_BUS_IRQ_MASK_BUF_DONE(sg)   FIELD_PREP(TFE_BUS_IRQ_MASK_BUF_DONE_MASK, BIT(sg))
+#define                TFE_BUS_IRQ_MASK_0_CONS_VIOL    BIT(28)
+#define                TFE_BUS_IRQ_MASK_0_VIOL         BIT(30)
+#define                TFE_BUS_IRQ_MASK_0_IMG_VIOL     BIT(31)
+
+#define TFE_BUS_IRQ_MASK_1                             BUS_REG(0x1c)
+#define TFE_BUS_IRQ_CLEAR_0                            BUS_REG(0x20)
+#define TFE_BUS_IRQ_STATUS_0                           BUS_REG(0x28)
+#define TFE_BUS_IRQ_CMD                                        BUS_REG(0x30)
+#define                TFE_BUS_IRQ_CMD_CLEAR           BIT(0)
+
+#define TFE_BUS_STATUS_CLEAR                           BUS_REG(0x60)
+#define TFE_BUS_VIOLATION_STATUS                       BUS_REG(0x64)
+#define TFE_BUS_OVERFLOW_STATUS                                BUS_REG(0x68)
+#define TFE_BUS_IMAGE_SZ_VIOLATION_STATUS              BUS_REG(0x70)
+
+#define TFE_BUS_CLIENT_CFG(c)                          BUS_REG(0x200 + (c) * 0x100)
+#define                TFE_BUS_CLIENT_CFG_EN           BIT(0)
+#define                TFE_BUS_CLIENT_CFG_MODE_FRAME   BIT(16)
+#define TFE_BUS_IMAGE_ADDR(c)                          BUS_REG(0x204 + (c) * 0x100)
+#define TFE_BUS_FRAME_INCR(c)                          BUS_REG(0x208 + (c) * 0x100)
+#define TFE_BUS_IMAGE_CFG_0(c)                         BUS_REG(0x20c + (c) * 0x100)
+#define                TFE_BUS_IMAGE_CFG_0_DEFAULT     0xffff
+#define TFE_BUS_IMAGE_CFG_1(c)                         BUS_REG(0x210 + (c) * 0x100)
+#define TFE_BUS_IMAGE_CFG_2(c)                         BUS_REG(0x214 + (c) * 0x100)
+#define                TFE_BUS_IMAGE_CFG_2_DEFAULT     0xffff
+#define TFE_BUS_PACKER_CFG(c)                          BUS_REG(0x218 + (c) * 0x100)
+#define                TFE_BUS_PACKER_CFG_FMT_PLAIN64  0xa
+#define TFE_BUS_IRQ_SUBSAMPLE_CFG_0(c)                 BUS_REG(0x230 + (c) * 0x100)
+#define TFE_BUS_IRQ_SUBSAMPLE_CFG_1(c)                 BUS_REG(0x234 + (c) * 0x100)
+#define TFE_BUS_FRAMEDROP_CFG_0(c)                     BUS_REG(0x238 + (c) * 0x100)
+#define TFE_BUS_FRAMEDROP_CFG_1(c)                     BUS_REG(0x23c + (c) * 0x100)
+
+/*
+ * TODO: differentiate the port id based on requested type of RDI, BHIST etc
+ *
+ * TFE write master IDs (clients)
+ *
+ * BAYER               0
+ * IDEAL_RAW           1
+ * STATS_TINTLESS_BG   2
+ * STATS_BHIST         3
+ * STATS_AWB_BG                4
+ * STATS_AEC_BG                5
+ * STATS_BAF           6
+ * RDI0                        7
+ * RDI1                        8
+ * RDI2                        9
+ */
+#define RDI_WM(n)              (7 + (n))
+#define TFE_WM_NUM             10
+
+enum tfe_iface {
+       TFE_IFACE_PIX,
+       TFE_IFACE_RDI0,
+       TFE_IFACE_RDI1,
+       TFE_IFACE_RDI2,
+       TFE_IFACE_NUM
+};
+
+enum tfe_subgroups {
+       TFE_SUBGROUP_BAYER,
+       TFE_SUBGROUP_IDEAL_RAW,
+       TFE_SUBGROUP_HDR,
+       TFE_SUBGROUP_BG,
+       TFE_SUBGROUP_BAF,
+       TFE_SUBGROUP_RDI0,
+       TFE_SUBGROUP_RDI1,
+       TFE_SUBGROUP_RDI2,
+       TFE_SUBGROUP_NUM
+};
+
+static enum tfe_iface tfe_line_iface_map[VFE_LINE_NUM_MAX] = {
+       [VFE_LINE_RDI0] = TFE_IFACE_RDI0,
+       [VFE_LINE_RDI1] = TFE_IFACE_RDI1,
+       [VFE_LINE_RDI2] = TFE_IFACE_RDI2,
+       [VFE_LINE_PIX] = TFE_IFACE_PIX,
+};
+
+static enum vfe_line_id tfe_subgroup_line_map[TFE_SUBGROUP_NUM] = {
+       [TFE_SUBGROUP_BAYER] = VFE_LINE_PIX,
+       [TFE_SUBGROUP_IDEAL_RAW] = VFE_LINE_PIX,
+       [TFE_SUBGROUP_HDR] = VFE_LINE_PIX,
+       [TFE_SUBGROUP_BG] = VFE_LINE_PIX,
+       [TFE_SUBGROUP_BAF] = VFE_LINE_PIX,
+       [TFE_SUBGROUP_RDI0] = VFE_LINE_RDI0,
+       [TFE_SUBGROUP_RDI1] = VFE_LINE_RDI1,
+       [TFE_SUBGROUP_RDI2] = VFE_LINE_RDI2,
+};
+
+static inline enum tfe_iface  __line_to_iface(enum vfe_line_id line_id)
+{
+       if (line_id <= VFE_LINE_NONE || line_id >= VFE_LINE_NUM_MAX) {
+               pr_warn("VFE: Invalid line %d\n", line_id);
+               return TFE_IFACE_RDI0;
+       }
+
+       return tfe_line_iface_map[line_id];
+}
+
+static inline enum vfe_line_id __iface_to_line(unsigned int iface)
+{
+       int i;
+
+       for (i = 0; i < VFE_LINE_NUM_MAX; i++) {
+               if (tfe_line_iface_map[i] == iface)
+                       return i;
+       }
+
+       return VFE_LINE_NONE;
+}
+
+static inline enum vfe_line_id __subgroup_to_line(enum tfe_subgroups sg)
+{
+       if (sg >= TFE_SUBGROUP_NUM)
+               return VFE_LINE_NONE;
+
+       return tfe_subgroup_line_map[sg];
+}
+
+static void vfe_global_reset(struct vfe_device *vfe)
+{
+       writel(TFE_IRQ_MASK_0_RST_DONE, vfe->base + TFE_IRQ_MASK_0);
+       writel(TFE_GLOBAL_RESET_CMD_CORE, vfe->base + TFE_GLOBAL_RESET_CMD);
+}
+
+static irqreturn_t vfe_isr(int irq, void *dev)
+{
+       struct vfe_device *vfe = dev;
+       u32 status;
+       int i;
+
+       status = readl_relaxed(vfe->base + TFE_IRQ_STATUS_0);
+       writel_relaxed(status, vfe->base + TFE_IRQ_CLEAR_0);
+       writel_relaxed(TFE_IRQ_CMD_CLEAR, vfe->base + TFE_IRQ_CMD);
+
+       if (status & TFE_IRQ_MASK_0_RST_DONE) {
+               dev_dbg(vfe->camss->dev, "VFE%u: Reset done!", vfe->id);
+               vfe_isr_reset_ack(vfe);
+       }
+
+       if (status & TFE_IRQ_MASK_0_BUS_WR) {
+               u32 bus_status = readl_relaxed(vfe->base + TFE_BUS_IRQ_STATUS_0);
+
+               writel_relaxed(bus_status, vfe->base + TFE_BUS_IRQ_CLEAR_0);
+               writel_relaxed(TFE_BUS_IRQ_CMD_CLEAR, vfe->base + TFE_BUS_IRQ_CMD);
+
+               for (i = 0; i < TFE_IFACE_NUM; i++) {
+                       if (bus_status & TFE_BUS_IRQ_MASK_RUP_DONE(i))
+                               vfe->res->hw_ops->reg_update_clear(vfe, __iface_to_line(i));
+               }
+
+               for (i = 0; i < TFE_SUBGROUP_NUM; i++) {
+                       if (bus_status & TFE_BUS_IRQ_MASK_BUF_DONE(i))
+                               vfe_buf_done(vfe, __subgroup_to_line(i));
+               }
+
+               if (bus_status & TFE_BUS_IRQ_MASK_0_CONS_VIOL)
+                       dev_err_ratelimited(vfe->camss->dev, "VFE%u: Bad config violation",
+                                           vfe->id);
+
+               if (bus_status & TFE_BUS_IRQ_MASK_0_VIOL)
+                       dev_err_ratelimited(vfe->camss->dev, "VFE%u: Input data violation",
+                                           vfe->id);
+
+               if (bus_status & TFE_BUS_IRQ_MASK_0_IMG_VIOL)
+                       dev_err_ratelimited(vfe->camss->dev, "VFE%u: Image size violation",
+                                           vfe->id);
+       }
+
+       status = readl_relaxed(vfe->base + TFE_BUS_OVERFLOW_STATUS);
+       if (status) {
+               writel_relaxed(status, vfe->base + TFE_BUS_STATUS_CLEAR);
+               for (i = 0; i < TFE_WM_NUM; i++) {
+                       if (status & BIT(i))
+                               dev_err_ratelimited(vfe->camss->dev,
+                                                   "VFE%u: bus overflow for wm %u\n",
+                                                   vfe->id, i);
+               }
+       }
+
+       return IRQ_HANDLED;
+}
+
+static int vfe_halt(struct vfe_device *vfe)
+{
+       /* rely on vfe_disable_output() to stop the VFE */
+       return 0;
+}
+
+static void vfe_enable_irq(struct vfe_device *vfe)
+{
+       writel(TFE_IRQ_MASK_0_RST_DONE | TFE_IRQ_MASK_0_BUS_WR,
+              vfe->base + TFE_IRQ_MASK_0);
+       writel(TFE_BUS_IRQ_MASK_RUP_DONE_MASK | TFE_BUS_IRQ_MASK_BUF_DONE_MASK |
+              TFE_BUS_IRQ_MASK_0_CONS_VIOL | TFE_BUS_IRQ_MASK_0_VIOL |
+              TFE_BUS_IRQ_MASK_0_IMG_VIOL, vfe->base + TFE_BUS_IRQ_MASK_0);
+}
+
+static void vfe_wm_update(struct vfe_device *vfe, u8 rdi, u32 addr,
+                         struct vfe_line *line)
+{
+       u8 wm = RDI_WM(rdi);
+
+       writel_relaxed(addr, vfe->base + TFE_BUS_IMAGE_ADDR(wm));
+}
+
+static void vfe_wm_start(struct vfe_device *vfe, u8 rdi, struct vfe_line *line)
+{
+       struct v4l2_pix_format_mplane *pix = &line->video_out.active_fmt.fmt.pix_mp;
+       u32 stride = pix->plane_fmt[0].bytesperline;
+       u8 wm = RDI_WM(rdi);
+
+       /* Configuration for plain RDI frames */
+       writel_relaxed(TFE_BUS_IMAGE_CFG_0_DEFAULT, vfe->base + TFE_BUS_IMAGE_CFG_0(wm));
+       writel_relaxed(0u, vfe->base + TFE_BUS_IMAGE_CFG_1(wm));
+       writel_relaxed(TFE_BUS_IMAGE_CFG_2_DEFAULT, vfe->base + TFE_BUS_IMAGE_CFG_2(wm));
+       writel_relaxed(stride * pix->height, vfe->base + TFE_BUS_FRAME_INCR(wm));
+       writel_relaxed(TFE_BUS_PACKER_CFG_FMT_PLAIN64, vfe->base + TFE_BUS_PACKER_CFG(wm));
+
+       /* No dropped frames, one irq per frame */
+       writel_relaxed(0, vfe->base + TFE_BUS_FRAMEDROP_CFG_0(wm));
+       writel_relaxed(1, vfe->base + TFE_BUS_FRAMEDROP_CFG_1(wm));
+       writel_relaxed(0, vfe->base + TFE_BUS_IRQ_SUBSAMPLE_CFG_0(wm));
+       writel_relaxed(1, vfe->base + TFE_BUS_IRQ_SUBSAMPLE_CFG_1(wm));
+
+       vfe_enable_irq(vfe);
+
+       writel(TFE_BUS_CLIENT_CFG_EN | TFE_BUS_CLIENT_CFG_MODE_FRAME,
+              vfe->base + TFE_BUS_CLIENT_CFG(wm));
+
+       dev_dbg(vfe->camss->dev, "VFE%u: Started RDI%u width %u height %u stride %u\n",
+               vfe->id, rdi, pix->width, pix->height, stride);
+}
+
+static void vfe_wm_stop(struct vfe_device *vfe, u8 rdi)
+{
+       u8 wm = RDI_WM(rdi);
+
+       writel(0, vfe->base + TFE_BUS_CLIENT_CFG(wm));
+
+       dev_dbg(vfe->camss->dev, "VFE%u: Stopped RDI%u\n", vfe->id, rdi);
+}
+
+static const struct camss_video_ops vfe_video_ops_520 = {
+       .queue_buffer = vfe_queue_buffer_v2,
+       .flush_buffers = vfe_flush_buffers,
+};
+
+static void vfe_subdev_init(struct device *dev, struct vfe_device *vfe)
+{
+       vfe->video_ops = vfe_video_ops_520;
+}
+
+static void vfe_reg_update(struct vfe_device *vfe, enum vfe_line_id line_id)
+{
+       vfe->reg_update |= BIT(__line_to_iface(line_id));
+       writel_relaxed(vfe->reg_update, vfe->base + TFE_REG_UPDATE_CMD);
+}
+
+static void vfe_reg_update_clear(struct vfe_device *vfe, enum vfe_line_id line_id)
+{
+       vfe->reg_update &= ~BIT(__line_to_iface(line_id));
+}
+
+const struct vfe_hw_ops vfe_ops_340 = {
+       .global_reset = vfe_global_reset,
+       .hw_version = vfe_hw_version,
+       .isr = vfe_isr,
+       .pm_domain_off = vfe_pm_domain_off,
+       .pm_domain_on = vfe_pm_domain_on,
+       .subdev_init = vfe_subdev_init,
+       .vfe_disable = vfe_disable,
+       .vfe_enable = vfe_enable_v2,
+       .vfe_halt = vfe_halt,
+       .vfe_wm_start = vfe_wm_start,
+       .vfe_wm_stop = vfe_wm_stop,
+       .vfe_buf_done = vfe_buf_done,
+       .vfe_wm_update = vfe_wm_update,
+       .reg_update = vfe_reg_update,
+       .reg_update_clear = vfe_reg_update_clear,
+};
index a23f666be7531e0366c73faea44ed245e7a8e30f..9b138849caca015bade5d98fcf34014ff4833ea0 100644 (file)
@@ -242,6 +242,7 @@ extern const struct vfe_hw_ops vfe_ops_4_1;
 extern const struct vfe_hw_ops vfe_ops_4_7;
 extern const struct vfe_hw_ops vfe_ops_4_8;
 extern const struct vfe_hw_ops vfe_ops_170;
+extern const struct vfe_hw_ops vfe_ops_340;
 extern const struct vfe_hw_ops vfe_ops_480;
 extern const struct vfe_hw_ops vfe_ops_680;
 extern const struct vfe_hw_ops vfe_ops_780;