]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
block: remove checks for FALLOC_FL_NO_HIDE_STALE
authorChristoph Hellwig <hch@lst.de>
Tue, 27 Aug 2024 06:50:45 +0000 (08:50 +0200)
committerChristian Brauner <brauner@kernel.org>
Wed, 28 Aug 2024 14:53:57 +0000 (16:53 +0200)
While the FALLOC_FL_NO_HIDE_STALE value has been registered, it has
always been rejected by vfs_fallocate before making it into
blkdev_fallocate because it isn't in the supported mask.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/r/20240827065123.1762168-2-hch@lst.de
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Jan Kara <jack@suse.cz>
Signed-off-by: Christian Brauner <brauner@kernel.org>
block/fops.c

index 9825c1713a49a98a9e9e6ff705b96c7fc10d038d..7f48f03a62e9a86d3b3c936650939717a7ef18fe 100644 (file)
@@ -771,7 +771,7 @@ reexpand:
 
 #define        BLKDEV_FALLOC_FL_SUPPORTED                                      \
                (FALLOC_FL_KEEP_SIZE | FALLOC_FL_PUNCH_HOLE |           \
-                FALLOC_FL_ZERO_RANGE | FALLOC_FL_NO_HIDE_STALE)
+                FALLOC_FL_ZERO_RANGE)
 
 static long blkdev_fallocate(struct file *file, int mode, loff_t start,
                             loff_t len)
@@ -830,14 +830,6 @@ static long blkdev_fallocate(struct file *file, int mode, loff_t start,
                                             len >> SECTOR_SHIFT, GFP_KERNEL,
                                             BLKDEV_ZERO_NOFALLBACK);
                break;
-       case FALLOC_FL_PUNCH_HOLE | FALLOC_FL_KEEP_SIZE | FALLOC_FL_NO_HIDE_STALE:
-               error = truncate_bdev_range(bdev, file_to_blk_mode(file), start, end);
-               if (error)
-                       goto fail;
-
-               error = blkdev_issue_discard(bdev, start >> SECTOR_SHIFT,
-                                            len >> SECTOR_SHIFT, GFP_KERNEL);
-               break;
        default:
                error = -EOPNOTSUPP;
        }