]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drm/drm-bridge: Drop conditionals around of_node pointers
authorSui Jingfeng <sui.jingfeng@linux.dev>
Tue, 7 May 2024 18:00:00 +0000 (02:00 +0800)
committerRobert Foss <rfoss@kernel.org>
Wed, 8 May 2024 13:44:21 +0000 (15:44 +0200)
Having conditional around the of_node pointer of the drm_bridge structure
is not necessary, since drm_bridge structure always has the of_node as its
member.

Let's drop the conditional to get a better looks, please also note that
this is following the already accepted commitments. see commit d8dfccde2709
("drm/bridge: Drop conditionals around of_node pointers") for reference.

Signed-off-by: Sui Jingfeng <sui.jingfeng@linux.dev>
Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Signed-off-by: Robert Foss <rfoss@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20240507180001.1358816-1-sui.jingfeng@linux.dev
drivers/gpu/drm/drm_bridge.c

index 28abe9aa99ca574ab77804ff82435784841d7383..584d109330ab13b17c0136b2045123fbfebbe48a 100644 (file)
@@ -353,13 +353,8 @@ err_reset_bridge:
        bridge->encoder = NULL;
        list_del(&bridge->chain_node);
 
-#ifdef CONFIG_OF
        DRM_ERROR("failed to attach bridge %pOF to encoder %s: %d\n",
                  bridge->of_node, encoder->name, ret);
-#else
-       DRM_ERROR("failed to attach bridge to encoder %s: %d\n",
-                 encoder->name, ret);
-#endif
 
        return ret;
 }