]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
iio: adc: qcom-spmi-iadc: Fix wakeup source leaks on device unbind
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Sun, 6 Apr 2025 20:01:43 +0000 (22:01 +0200)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Sat, 12 Apr 2025 11:24:00 +0000 (12:24 +0100)
Device can be unbound, so driver must also release memory for the wakeup
source.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://patch.msgid.link/20250406-b4-device-wakeup-leak-iio-v1-2-2d7d322a4a93@linaro.org
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/adc/qcom-spmi-iadc.c

index 7fb8b2499a1d00e4a020da893181e693650726bd..b64a8a407168bbc109e6ea9a63b8c4e492ac5bf4 100644 (file)
@@ -543,7 +543,9 @@ static int iadc_probe(struct platform_device *pdev)
                else
                        return ret;
        } else {
-               device_init_wakeup(iadc->dev, 1);
+               ret = devm_device_init_wakeup(iadc->dev);
+               if (ret)
+                       return dev_err_probe(iadc->dev, ret, "Failed to init wakeup\n");
        }
 
        ret = iadc_update_offset(iadc);