]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
thermal: int340x: Clean up _OSC context init
authorDavidlohr Bueso <dave@stgolabs.net>
Thu, 24 Mar 2022 19:09:50 +0000 (12:09 -0700)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Tue, 5 Apr 2022 18:25:21 +0000 (20:25 +0200)
Now that the UUID is already sanitized by the caller,
lets trivially clean up some of the context arming.

Signed-off-by: Davidlohr Bueso <dave@stgolabs.net>
Acked-by: Zhang Rui <rui.zhang@intel.com>
[ rjw: Subject edits ]
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/thermal/intel/int340x_thermal/int3400_thermal.c

index e299873d50b8c99670db9df07e30fc063df990e5..4c49a6c9d4df868d3e0dedfcb1a21f8eacacbe6c 100644 (file)
@@ -169,18 +169,15 @@ static int int3400_thermal_run_osc(acpi_handle handle, char *uuid_str, int *enab
        acpi_status status;
        int result = 0;
        struct acpi_osc_context context = {
-               .uuid_str = NULL,
+               .uuid_str = uuid_str,
                .rev = 1,
                .cap.length = 8,
+               .cap.pointer = buf,
        };
 
-       context.uuid_str = uuid_str;
-
        buf[OSC_QUERY_DWORD] = 0;
        buf[OSC_SUPPORT_DWORD] = *enable;
 
-       context.cap.pointer = buf;
-
        status = acpi_run_osc(handle, &context);
        if (ACPI_SUCCESS(status)) {
                ret = *((u32 *)(context.ret.pointer + 4));