t5300: fix test_with_bad_commit()

0f8edf7317 (index-pack: --fsck-objects to take an optional argument for
fsck msgs, 2024-02-01) added a test function test_with_bad_commit() that
contained two bugs. test_expect_fail was used instead of test_must_fail,
and a && was not included at the end of the line.

Fix these two issues in the test.

Signed-off-by: John Cai <johncai86@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/t/t5300-pack-object.sh b/t/t5300-pack-object.sh
index a58f91035d124d6710438c5524c91bdbf66b4e84..61e2be2903d344563fe2ebea718de962e60d7b78 100755 (executable)
--- a/t/t5300-pack-object.sh
+++ b/t/t5300-pack-object.sh
@@ -465,7 +465,7 @@ test_with_bad_commit () {
        must_pass_arg="$2" &&
        (
                cd strict &&
-               test_expect_fail git index-pack "$must_fail_arg" "test-$(cat pack-name).pack"
+               test_must_fail git index-pack "$must_fail_arg" "test-$(cat pack-name).pack" &&
                git index-pack "$must_pass_arg" "test-$(cat pack-name).pack"
        )
 }