tools/depmod: avoid casting symbol_free() function type

With clang 17, -fsanitize=function is enabled alongside any other
sanitizers. Which flags undefined behaviour, since the function type
(argument type really) is not compatible.

Reference: https://reviews.llvm.org/D148827#4422631
Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Link: https://github.com/kmod-project/kmod/pull/180
Signed-off-by: Lucas De Marchi <lucas.de.marchi@gmail.com>

diff --git a/tools/depmod.c b/tools/depmod.c
index d71c31b737340aad56dd11a4980e9efb80779d6c..a28666c7d9223fd4f0ce2d3369f1b73cf047fd62 100644 (file)
--- a/tools/depmod.c
+++ b/tools/depmod.c
@@ -960,8 +960,10 @@ static int mod_add_dependency(struct mod *mod, struct symbol *sym)
        return 0;
 }
 
-static void symbol_free(struct symbol *sym)
+static void symbol_free(void *data)
 {
+       struct symbol *sym = data;
+
        DBG("free %p sym=%s, owner=%p %s\n", sym, sym->name, sym->owner,
            sym->owner != NULL ? sym->owner->path : "");
        free(sym);
@@ -988,7 +990,7 @@ static int depmod_init(struct depmod *depmod, struct cfg *cfg, struct kmod_ctx *
                goto modules_by_name_failed;
        }
 
-       depmod->symbols = hash_new(2048, (void (*)(void *))symbol_free);
+       depmod->symbols = hash_new(2048, symbol_free);
        if (depmod->symbols == NULL) {
                err = -errno;
                goto symbols_failed;