]> git.ipfire.org Git - thirdparty/git.git/commitdiff
t5544: clarify 'hook works with partial clone' test
authorJacob Vosmaer <jacob@gitlab.com>
Tue, 2 Feb 2021 19:24:17 +0000 (20:24 +0100)
committerJunio C Hamano <gitster@pobox.com>
Tue, 2 Feb 2021 20:21:38 +0000 (12:21 -0800)
Apply a few leftover improvements from the review of ad5df6b782
(upload-pack.c: fix filter spec quoting bug).

1. Instead of enumerating objects reachable from HEAD, enumerate all
reachable objects, because HEAD has not special significance in this
test.

2. Instead of relying on the knowledge that "? in rev-list output
means partial clone", explicitly verify that there are no blobs with
cat-file.

Signed-off-by: Jacob Vosmaer <jacob@gitlab.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
t/t5544-pack-objects-hook.sh

index f5ba663d645f594bf631302842b34a15729f4bdf..dd5f44d986f2f774313ca11e7a1bfecf87060e7e 100755 (executable)
@@ -64,8 +64,9 @@ test_expect_success 'hook works with partial clone' '
        test_config_global uploadpack.packObjectsHook ./hook &&
        test_config_global uploadpack.allowFilter true &&
        git clone --bare --no-local --filter=blob:none . dst.git &&
-       git -C dst.git rev-list --objects --missing=print HEAD >objects &&
-       grep "^?" objects
+       git -C dst.git rev-list --objects --missing=allow-any --no-object-names --all >objects &&
+       git -C dst.git cat-file --batch-check="%(objecttype)" <objects >types &&
+       ! grep blob types
 '
 
 test_done