]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
irqchip/renesas-rzv2h: Use devm_reset_control_get_exclusive_deasserted()
authorBiju Das <biju.das.jz@bp.renesas.com>
Mon, 24 Feb 2025 13:11:21 +0000 (13:11 +0000)
committerThomas Gleixner <tglx@linutronix.de>
Wed, 26 Feb 2025 10:59:49 +0000 (11:59 +0100)
Use devm_reset_control_get_exclusive_deasserted() to simplify
rzv2h_icu_init().

Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
Link: https://lore.kernel.org/all/20250224131253.134199-6-biju.das.jz@bp.renesas.com
drivers/irqchip/irq-renesas-rzv2h.c

index d724f32dde8f2b93d4df50e15e1fa030cbe6b885..edae54f9f5da57b59f0cc295378d397eb4957248 100644 (file)
@@ -461,13 +461,10 @@ static int rzv2h_icu_init(struct device_node *node, struct device_node *parent)
                return ret;
        }
 
-       resetn = devm_reset_control_get_exclusive(&pdev->dev, NULL);
-       if (IS_ERR(resetn))
-               return PTR_ERR(resetn);
-
-       ret = reset_control_deassert(resetn);
-       if (ret) {
-               dev_err(&pdev->dev, "failed to deassert resetn pin, %d\n", ret);
+       resetn = devm_reset_control_get_exclusive_deasserted(&pdev->dev, NULL);
+       if (IS_ERR(resetn)) {
+               ret = PTR_ERR(resetn);
+               dev_err(&pdev->dev, "failed to acquire deasserted reset: %d\n", ret);
                return ret;
        }
 
@@ -498,7 +495,6 @@ pm_put:
        pm_runtime_put(&pdev->dev);
 pm_disable:
        pm_runtime_disable(&pdev->dev);
-       reset_control_assert(resetn);
 
        return ret;
 }