]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
perf/hw_breakpoint: use ERR_PTR_PCPU(), IS_ERR_PCPU() and PTR_ERR_PCPU() macros
authorUros Bizjak <ubizjak@gmail.com>
Tue, 24 Sep 2024 09:07:13 +0000 (11:07 +0200)
committerAndrew Morton <akpm@linux-foundation.org>
Wed, 6 Nov 2024 01:12:32 +0000 (17:12 -0800)
Use ERR_PTR_PCPU() when returning error pointer in the percpu address
space.  Use IS_ERR_PCPU() and PTR_ERR_PCPU() when returning the error
pointer from the percpu address space.  These macros add intermediate cast
to unsigned long when switching named address spaces.

The patch will avoid future build errors due to pointer address space
mismatch with enabled strict percpu address space checks.

Link: https://lkml.kernel.org/r/20240924090813.1353586-1-ubizjak@gmail.com
Signed-off-by: Uros Bizjak <ubizjak@gmail.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Ian Rogers <irogers@google.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: "Liang, Kan" <kan.liang@linux.intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
kernel/events/hw_breakpoint.c
samples/hw_breakpoint/data_breakpoint.c

index 6c2cb4e4f48dabff9875b39822c4981491c47ab2..bc4a61029b6dcac641f1d883513aa41a819911c5 100644 (file)
@@ -849,7 +849,7 @@ register_wide_hw_breakpoint(struct perf_event_attr *attr,
 
        cpu_events = alloc_percpu(typeof(*cpu_events));
        if (!cpu_events)
-               return (void __percpu __force *)ERR_PTR(-ENOMEM);
+               return ERR_PTR_PCPU(-ENOMEM);
 
        cpus_read_lock();
        for_each_online_cpu(cpu) {
@@ -868,7 +868,7 @@ register_wide_hw_breakpoint(struct perf_event_attr *attr,
                return cpu_events;
 
        unregister_wide_hw_breakpoint(cpu_events);
-       return (void __percpu __force *)ERR_PTR(err);
+       return ERR_PTR_PCPU(err);
 }
 EXPORT_SYMBOL_GPL(register_wide_hw_breakpoint);
 
index a2c831e89ce0e9e090aa4684cfb4924b9d25d64e..fbb03b66dcbd135e38acededa93cac6427fbc8b6 100644 (file)
@@ -52,8 +52,8 @@ static int __init hw_break_module_init(void)
        attr.bp_type = HW_BREAKPOINT_W;
 
        sample_hbp = register_wide_hw_breakpoint(&attr, sample_hbp_handler, NULL);
-       if (IS_ERR((void __force *)sample_hbp)) {
-               ret = PTR_ERR((void __force *)sample_hbp);
+       if (IS_ERR_PCPU(sample_hbp)) {
+               ret = PTR_ERR_PCPU(sample_hbp);
                goto fail;
        }