]> git.ipfire.org Git - thirdparty/gcc.git/commitdiff
rs6000: Guard fctid on PowerPC64 and PowerPC476
authorHaochen Gui <guihaoc@gcc.gnu.org>
Mon, 11 Dec 2023 00:41:55 +0000 (08:41 +0800)
committerHaochen Gui <guihaoc@gcc.gnu.org>
Mon, 11 Dec 2023 00:46:10 +0000 (08:46 +0800)
fctid is only supported on 64-bit Power processors and powerpc 476. It
should be guarded by this condition. The patch fixes the issue.

gcc/
PR target/112707
* config/rs6000/rs6000.h (TARGET_FCTID): Define.
* config/rs6000/rs6000.md (lrint<mode>di2): Add guard TARGET_FCTID.
* (lround<mode>di2): Replace TARGET_FPRND with TARGET_FCTID.

gcc/testsuite/
PR target/112707
* gcc.target/powerpc/pr112707.h: New.
* gcc.target/powerpc/pr112707-2.c: New.
* gcc.target/powerpc/pr112707-3.c: New.
* gcc.target/powerpc/pr88558-p7.c: Check fctid on ilp32 and
has_arch_ppc64 as it's now guarded by powerpc64.
* gcc.target/powerpc/pr88558-p8.c: Likewise.
* gfortran.dg/nint_p7.f90: Add powerpc64 target requirement as
lround<mode>di2 is now guarded by powerpc64.

gcc/config/rs6000/rs6000.h
gcc/config/rs6000/rs6000.md
gcc/testsuite/gcc.target/powerpc/pr112707-2.c [new file with mode: 0644]
gcc/testsuite/gcc.target/powerpc/pr112707-3.c [new file with mode: 0644]
gcc/testsuite/gcc.target/powerpc/pr112707.h [new file with mode: 0644]
gcc/testsuite/gcc.target/powerpc/pr88558-p7.c
gcc/testsuite/gcc.target/powerpc/pr88558-p8.c
gcc/testsuite/gfortran.dg/nint_p7.f90

index 326c45221e9c66f0b11daa8d22bc28ab35b4201d..df44b86fb05ce4ba0afd44d3bc78dd8669810265 100644 (file)
@@ -467,6 +467,8 @@ extern int rs6000_vector_align[];
 #define TARGET_FCFIDUS TARGET_POPCNTD
 #define TARGET_FCTIDUZ TARGET_POPCNTD
 #define TARGET_FCTIWUZ TARGET_POPCNTD
+/* Only powerpc64 and powerpc476 support fctid.  */
+#define TARGET_FCTID   (TARGET_POWERPC64 || rs6000_cpu == PROCESSOR_PPC476)
 #define TARGET_CTZ     TARGET_MODULO
 #define TARGET_EXTSWSLI        (TARGET_MODULO && TARGET_POWERPC64)
 #define TARGET_MADDLD  TARGET_MODULO
index 3d9491769fc4d6977458818a3f8a3cdaa123de55..58126628ca04e4f87bebecab431f791401d5f8e8 100644 (file)
   [(set (match_operand:DI 0 "gpc_reg_operand" "=d")
        (unspec:DI [(match_operand:SFDF 1 "gpc_reg_operand" "<rreg2>")]
                   UNSPEC_FCTID))]
-  "TARGET_HARD_FLOAT"
+  "TARGET_HARD_FLOAT && TARGET_FCTID"
   "fctid %0,%1"
   [(set_attr "type" "fp")])
 
    (set (match_operand:DI 0 "gpc_reg_operand")
        (unspec:DI [(match_dup 2)]
                   UNSPEC_FCTID))]
-  "TARGET_HARD_FLOAT && TARGET_VSX && TARGET_FPRND"
+  "TARGET_HARD_FLOAT && TARGET_VSX && TARGET_FCTID"
 {
   operands[2] = gen_reg_rtx (<MODE>mode);
 })
diff --git a/gcc/testsuite/gcc.target/powerpc/pr112707-2.c b/gcc/testsuite/gcc.target/powerpc/pr112707-2.c
new file mode 100644 (file)
index 0000000..672e006
--- /dev/null
@@ -0,0 +1,9 @@
+/* { dg-do compile } */
+/* { dg-options "-O2 -mdejagnu-cpu=7450 -fno-math-errno" } */
+/* { dg-require-effective-target ilp32 } */
+/* { dg-skip-if "" { has_arch_ppc64 } } */
+/* { dg-final { scan-assembler-not {\mfctid\M} } }  */
+
+/* powerpc 7450 doesn't support ppc64 (-m32 -mpowerpc64), so skips it.  */
+
+#include "pr112707.h"
diff --git a/gcc/testsuite/gcc.target/powerpc/pr112707-3.c b/gcc/testsuite/gcc.target/powerpc/pr112707-3.c
new file mode 100644 (file)
index 0000000..924338f
--- /dev/null
@@ -0,0 +1,9 @@
+/* { dg-do compile } */
+/* { dg-options "-O2 -fno-math-errno -mdejagnu-cpu=476fp" } */
+/* { dg-require-effective-target ilp32 } */
+
+/* powerpc 476fp has hard float enabled which is required by fctid */
+
+#include "pr112707.h"
+
+/* { dg-final { scan-assembler-times {\mfctid\M} 2 } } */
diff --git a/gcc/testsuite/gcc.target/powerpc/pr112707.h b/gcc/testsuite/gcc.target/powerpc/pr112707.h
new file mode 100644 (file)
index 0000000..e427dc6
--- /dev/null
@@ -0,0 +1,10 @@
+long long test1 (double a)
+{
+  return __builtin_llrint (a);
+}
+
+long long test2 (float a)
+{
+  return __builtin_llrint (a);
+}
+
index 3932656c5fd9fe22cac92ce5f63f15937f376589..2fa0b997e52fb4c282fa7389c2b7e085b13402a1 100644 (file)
@@ -6,7 +6,7 @@
 #include "pr88558.h"
 
 /* { dg-final { scan-assembler-times {\mfctid\M} 4 { target lp64 } } } */
-/* { dg-final { scan-assembler-times {\mfctid\M} 2 { target ilp32 } } } */
+/* { dg-final { scan-assembler-times {\mfctid\M} 2 { target { ilp32 && has_arch_ppc64 } } } } */
 /* { dg-final { scan-assembler-times {\mfctiw\M} 2 { target lp64 } } } */
 /* { dg-final { scan-assembler-times {\mfctiw\M} 4 { target ilp32 } } } */
 /* { dg-final { scan-assembler-times {\mstfiwx\M} 2 { target lp64 } } } */
index 1afc8fd4f0d185c8e0dbc7948e722b56ffcfb3f0..fffb5b88c209d5b095eda499354a7bf4a5c69154 100644 (file)
@@ -7,7 +7,7 @@
 #include "pr88558.h"
 
 /* { dg-final { scan-assembler-times {\mfctid\M} 4 { target lp64 } } } */
-/* { dg-final { scan-assembler-times {\mfctid\M} 2 { target ilp32 } } } */
+/* { dg-final { scan-assembler-times {\mfctid\M} 2 { target { ilp32 && has_arch_ppc64 } } } } */
 /* { dg-final { scan-assembler-times {\mfctiw\M} 2 { target lp64 } } } */
 /* { dg-final { scan-assembler-times {\mfctiw\M} 4 { target ilp32 } } } */
 /* { dg-final { scan-assembler-times {\mmfvsrwz\M} 2 { target lp64 } } } */
index 2239824a7fb130f75f7089d6d8673c3a9451779a..c23eb6783bc3be4329117f2bfd7740b4a034b372 100644 (file)
@@ -2,6 +2,7 @@
 ! { dg-do compile { target { powerpc*-*-* } } }
 ! { dg-require-effective-target powerpc_vsx_ok } 
 ! { dg-options "-O2 -mdejagnu-cpu=power7 -ffast-math" } 
+! { dg-require-effective-target has_arch_ppc64 } 
 ! { dg-final { scan-assembler-times "xsrdpi" 2 } } 
 
        subroutine test_nint(x4,x8)