]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
media: i2c: imx335: Use the v4l2 helper for obtaining the clock
authorMehdi Djait <mehdi.djait@linux.intel.com>
Thu, 26 Jun 2025 13:34:06 +0000 (15:34 +0200)
committerHans Verkuil <hverkuil+cisco@kernel.org>
Wed, 13 Aug 2025 13:10:21 +0000 (15:10 +0200)
devm_clk_get() fails on ACPI-based platforms, where firmware does not
provide a direct reference to the clock producer.

Replace devm_clk_get() with the new v4l2 helper
devm_v4l2_sensor_clk_get() that works on both DT- and ACPI-based
platforms to retrieve a reference to the clock producer from firmware.

Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mehdi Djait <mehdi.djait@linux.intel.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
drivers/media/i2c/imx335.c

index 9b4db4cd4929caf83596e93d2ac3de2f54e892b0..c043df2f15fb25b3a56422092f99a1fd9a508fa9 100644 (file)
@@ -1026,11 +1026,10 @@ static int imx335_parse_hw_config(struct imx335 *imx335)
        }
 
        /* Get sensor input clock */
-       imx335->inclk = devm_clk_get(imx335->dev, NULL);
-       if (IS_ERR(imx335->inclk)) {
-               dev_err(imx335->dev, "could not get inclk\n");
-               return PTR_ERR(imx335->inclk);
-       }
+       imx335->inclk = devm_v4l2_sensor_clk_get(imx335->dev, NULL);
+       if (IS_ERR(imx335->inclk))
+               return dev_err_probe(imx335->dev, PTR_ERR(imx335->inclk),
+                                    "could not get inclk\n");
 
        rate = clk_get_rate(imx335->inclk);
        if (rate != IMX335_INCLK_RATE) {